Merge lp:~ken-vandine/autopilot/depends_for_gsettings into lp:autopilot

Proposed by Ken VanDine
Status: Merged
Merged at revision: 566
Proposed branch: lp:~ken-vandine/autopilot/depends_for_gsettings
Merge into: lp:autopilot
Diff against target: 19 lines (+2/-0)
1 file modified
debian/control (+2/-0)
To merge this branch: bzr merge lp:~ken-vandine/autopilot/depends_for_gsettings
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Iain Lane (community) Needs Fixing
Max Brustkern (community) Approve
Review via email: mp+265580@code.launchpad.net

Commit message

added depends for libglib2.0-bin

Description of the change

added depends for libglib2.0-bin

This is needed to fix autopkgtests that are now failing because of the recent gsettings addition.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

This looks good to me. I'll see what we can do about getting a release.

review: Approve
Revision history for this message
Ken VanDine (ken-vandine) wrote :
567. By Ken VanDine

Depend on ubuntu-keyboard-data for the gsettings schema

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Thanks, this should be good as well.

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

Can we please instead make this opt in with a soft depends for those tests/projects that need it? I don't see why all users of autopilot should be forced to do things to work around problems with the Ubuntu keyboard that may not remotely concern them.

And please let's use the proper API for interacting with gsettings instead of an administration tool.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Christopher Lee (veebers) wrote :

> Can we please instead make this opt in with a soft depends for those
> tests/projects that need it? I don't see why all users of autopilot should be
> forced to do things to work around problems with the Ubuntu keyboard that may
> not remotely concern them.
>
> And please let's use the proper API for interacting with gsettings instead of
> an administration tool.

These concerns should be address with this branch: https://code.launchpad.net/~canonical-platform-qa/autopilot/depends_for_gsettings/+merge/265621

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2015-07-16 03:24:34 +0000
+++ debian/control 2015-07-22 17:52:33 +0000
@@ -43,6 +43,7 @@
43Package: python3-autopilot43Package: python3-autopilot
44Architecture: all44Architecture: all
45Depends: gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,45Depends: gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,
46 libglib2.0-bin,
46 libjs-jquery,47 libjs-jquery,
47 libjs-underscore,48 libjs-underscore,
48 python3-dateutil,49 python3-dateutil,
@@ -56,6 +57,7 @@
56 python3-subunit,57 python3-subunit,
57 python3-testscenarios,58 python3-testscenarios,
58 python3-testtools,59 python3-testtools,
60 ubuntu-keyboard-data,
59 udev,61 udev,
60 ${misc:Depends},62 ${misc:Depends},
61 ${python3:Depends},63 ${python3:Depends},

Subscribers

People subscribed via source and target branches