Merge lp:~jury-verrigni/slingshot/fix-1636632 into lp:~elementary-pantheon/slingshot/trunk

Proposed by Jury Verrigni
Status: Rejected
Rejected by: David Hewitt
Proposed branch: lp:~jury-verrigni/slingshot/fix-1636632
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 20 lines (+2/-1)
1 file modified
src/Widgets/SearchView.vala (+2/-1)
To merge this branch: bzr merge lp:~jury-verrigni/slingshot/fix-1636632
Reviewer Review Type Date Requested Status
David Hewitt Disapprove
Corentin Noël Disapprove
Review via email: mp+313958@code.launchpad.net

Description of the change

Providing a link to the appcenter with the searched term.
Note that this depends on this merge-request https://code.launchpad.net/~jury-verrigni/appcenter/handle-search-via-uri-scheme

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

I don't think this is the right thing to do here. You're introducing hidden dependency to AppCenter when you can just use the libappstream library to search. Each AppStream Components has an unique id which can be given to AppCenter (or any software center) via the appstream:// URI.

review: Disapprove
Revision history for this message
David Hewitt (davidmhewitt) wrote :

This has now been implemented in an alternative way. Closing.

review: Disapprove

Unmerged revisions

712. By Jury Verrigni

Now providing search on the AppCenter if result is empty

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Widgets/SearchView.vala'
--- src/Widgets/SearchView.vala 2016-12-28 16:13:57 +0000
+++ src/Widgets/SearchView.vala 2017-01-02 09:59:19 +0000
@@ -57,7 +57,7 @@
57 case SearchItem.ResultType.APP_ACTIONS:57 case SearchItem.ResultType.APP_ACTIONS:
58 case SearchItem.ResultType.LINK:58 case SearchItem.ResultType.LINK:
59 case SearchItem.ResultType.SETTINGS:59 case SearchItem.ResultType.SETTINGS:
60 search_item.app.match.execute (null); 60 search_item.app.match.execute (null);
61 break;61 break;
62 default:62 default:
63 search_item.app.launch ();63 search_item.app.launch ();
@@ -151,6 +151,7 @@
151151
152 stack.set_visible_child_name ("results");152 stack.set_visible_child_name ("results");
153 } else {153 } else {
154 alert_view.description = _("Try changing terms or search the <a href=\"appstream://search/%s\">AppCenter</a>".printf (search_term));
154 alert_view.title = _("No Results for “%s”".printf (search_term));155 alert_view.title = _("No Results for “%s”".printf (search_term));
155 stack.set_visible_child_name ("alert");156 stack.set_visible_child_name ("alert");
156 }157 }

Subscribers

People subscribed via source and target branches