Merge lp:~jury-verrigni/slingshot/fix-1636632 into lp:~elementary-pantheon/slingshot/trunk
Proposed by
Jury Verrigni
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | David Hewitt | ||||
Proposed branch: | lp:~jury-verrigni/slingshot/fix-1636632 | ||||
Merge into: | lp:~elementary-pantheon/slingshot/trunk | ||||
Diff against target: |
20 lines (+2/-1) 1 file modified
src/Widgets/SearchView.vala (+2/-1) |
||||
To merge this branch: | bzr merge lp:~jury-verrigni/slingshot/fix-1636632 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Hewitt | Disapprove | ||
Corentin Noël | Disapprove | ||
Review via email: mp+313958@code.launchpad.net |
Description of the change
Providing a link to the appcenter with the searched term.
Note that this depends on this merge-request https:/
To post a comment you must log in.
Unmerged revisions
- 712. By Jury Verrigni
-
Now providing search on the AppCenter if result is empty
I don't think this is the right thing to do here. You're introducing hidden dependency to AppCenter when you can just use the libappstream library to search. Each AppStream Components has an unique id which can be given to AppCenter (or any software center) via the appstream:// URI.