Merge lp:~junaidali/charms/trusty/plumgrid-gateway/trunk into lp:~plumgrid-team/charms/trusty/plumgrid-gateway/trunk

Proposed by Junaid Ali
Status: Merged
Merged at revision: 30
Proposed branch: lp:~junaidali/charms/trusty/plumgrid-gateway/trunk
Merge into: lp:~plumgrid-team/charms/trusty/plumgrid-gateway/trunk
Diff against target: 62 lines (+2/-19)
3 files modified
config.yaml (+1/-11)
hooks/pg_gw_utils.py (+1/-7)
templates/kilo/ifcs.conf (+0/-1)
To merge this branch: bzr merge lp:~junaidali/charms/trusty/plumgrid-gateway/trunk
Reviewer Review Type Date Requested Status
Bilal Baqar Approve
Review via email: mp+297607@code.launchpad.net
To post a comment you must log in.
31. By Junaid Ali

Changes:
 Updated fabric-interfaces config description
 Removed unused imports

Revision history for this message
Bilal Baqar (bbaqar) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2015-11-22 03:26:23 +0000
+++ config.yaml 2016-06-19 18:55:17 +0000
@@ -13,22 +13,12 @@
13 type: string13 type: string
14 default: 'juju-br0'14 default: 'juju-br0'
15 description: The interface connected to PLUMgrid Managment network.15 description: The interface connected to PLUMgrid Managment network.
16 os-data-network:
17 type: string
18 default:
19 description: |
20 The IP address and netmask of the OpenStack Data network (e.g.,
21 192.168.0.0/24)
22 .
23 This network will be used for tenant network traffic in overlay
24 networks.
25 fabric-interfaces:16 fabric-interfaces:
26 default: 'MANAGEMENT'17 default: 'MANAGEMENT'
27 type: string18 type: string
28 description: |19 description: |
29 Interfaces that will provide fabric connectivity on the gateway nodes.20 Interfaces that will provide fabric connectivity on the gateway nodes.
30 Provided in form of json in a string. These interfaces have to be connected 21 Provided in form of json in a string. Default value is MANAGEMENT which
31 to the os-data-network specified in the config. Default value is MANAGEMENT which
32 will configure the management interface as the fabric interface on each22 will configure the management interface as the fabric interface on each
33 director.23 director.
34 network-device-mtu:24 network-device-mtu:
3525
=== modified file 'hooks/pg_gw_utils.py'
--- hooks/pg_gw_utils.py 2016-05-23 10:31:14 +0000
+++ hooks/pg_gw_utils.py 2016-06-19 18:55:17 +0000
@@ -23,8 +23,6 @@
23 get_iface_from_addr,23 get_iface_from_addr,
24 get_bridges,24 get_bridges,
25 get_bridge_nics,25 get_bridge_nics,
26 is_address_in_network,
27 get_iface_addr
28)26)
29from charmhelpers.core.host import (27from charmhelpers.core.host import (
30 write_file,28 write_file,
@@ -268,11 +266,7 @@
268 else:266 else:
269 raise ValueError('No fabric interface provided for node')267 raise ValueError('No fabric interface provided for node')
270 if interface_exists(node_fabric_interface):268 if interface_exists(node_fabric_interface):
271 if is_address_in_network(config('os-data-network'),269 return node_fabric_interface
272 get_iface_addr(node_fabric_interface)[0]):
273 return node_fabric_interface
274 else:
275 raise ValueError('Fabric interface not in fabric network')
276 else:270 else:
277 log('Provided fabric interface %s does not exist'271 log('Provided fabric interface %s does not exist'
278 % node_fabric_interface)272 % node_fabric_interface)
279273
=== modified file 'templates/kilo/ifcs.conf'
--- templates/kilo/ifcs.conf 2016-05-21 11:54:18 +0000
+++ templates/kilo/ifcs.conf 2016-06-19 18:55:17 +0000
@@ -4,4 +4,3 @@
4{{ dev }} = access_phys4{{ dev }} = access_phys
5{% endfor -%}5{% endfor -%}
6{% endif -%}6{% endif -%}
7

Subscribers

People subscribed via source and target branches