Merge lp:~julian-edwards/launchpad/ppa-search-oops-bug-446157 into lp:launchpad
Proposed by
Julian Edwards
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | not available | ||||
Proposed branch: | lp:~julian-edwards/launchpad/ppa-search-oops-bug-446157 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
42 lines 2 files modified
lib/lp/registry/browser/distribution.py (+7/-0) lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt (+14/-0) |
||||
To merge this branch: | bzr merge lp:~julian-edwards/launchpad/ppa-search-oops-bug-446157 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Nelson (community) | code | Approve | |
Review via email: mp+13361@code.launchpad.net |
To post a comment you must log in.
= Summary =
Fix an oops when someone hand-hacks URLs searching PPAs.
== Proposed fix ==
We need to cope with a list value when expecting a string in the form data.
This is a trivial change in the view code, but I also filed a Foundations bugs
since we should be able to do this generically in the form setup.
== Pre-implementation notes ==
None, I suck.
== Tests ==
bin/test -cvvt xx-ubuntu-ppas
== Demo and Q/A == /launchpad. dev/ubuntu/ +ppas?name_ filter= packages& name_filter= humanity
https:/
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: soyuz/stories/ ppa/xx- ubuntu- ppas.txt registry/ browser/ distribution. py
lib/lp/
lib/lp/