Merge lp:~julian-edwards/gwacl/delete-disk-media into lp:gwacl
Proposed by
Julian Edwards
Status: | Merged |
---|---|
Approved by: | Julian Edwards |
Approved revision: | 190 |
Merged at revision: | 186 |
Proposed branch: | lp:~julian-edwards/gwacl/delete-disk-media |
Merge into: | lp:gwacl |
Diff against target: |
170 lines (+46/-16) 5 files modified
deletedisk.go (+4/-3) deletedisk_test.go (+5/-5) management.go (+3/-1) management_base.go (+13/-6) management_base_test.go (+21/-1) |
To merge this branch: | bzr merge lp:~julian-edwards/gwacl/delete-disk-media |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Review via email: mp+174926@code.launchpad.net |
Commit message
Add a deleteBlob parameter to DeleteDisk, which tells Azure to delete the associated blob storage.
To post a comment you must log in.
Looks good!
[0]
92 // TODO: set comp=media to optionally delete associated blob.
93 -func (api *ManagementAPI) DeleteDisk(diskName string) error {
94 +func (api *ManagementAPI) DeleteDisk(diskName string, deleteBlob bool) error {
You can probably get rid of the TODO comment here (or better, turn it into a sentence explaining what 'deleteBlob' does).
[1]
92 // TODO: set comp=media to optionally delete associated blob.
93 -func (api *ManagementAPI) DeleteDisk(diskName string) error {
94 +func (api *ManagementAPI) DeleteDisk(diskName string, deleteBlob bool) error {
Since you're breaking backward compatibility already, what about putting all the parameters in a DeleteDiskRequest object?