Merge lp:~jtv/launchpad/bug-848954 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jeroen T. Vermeulen | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 13951 | ||||
Proposed branch: | lp:~jtv/launchpad/bug-848954 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
174 lines (+23/-33) 3 files modified
lib/lp/soyuz/scripts/gina/handlers.py (+4/-7) lib/lp/soyuz/scripts/gina/katie.py (+16/-17) scripts/gina.py (+3/-9) |
||||
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-848954 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+75188@code.launchpad.net |
Commit message
[r=gmb][bug=848954] Remove Gina's untested, unappreciated dry-run mode.
Description of the change
= Summary =
Gina has a dry-run mode.
This turned out to be a big surprise to both William and Julian, the people I most expected to be familiar with it. So I'll say it again to avoid any confusion: Gina has a dry-run mode.
Is it useful? That depends on whether it works. Does it work? We don't know. Are there any tests to prove that it works? We know there aren't. Breaking dry-run mode, as I did earlier, did not break any tests.
== Proposed fix ==
Rather than fixing and testing dry-run mode (the test would involve an extra, expensive script run), and if necessary fixing it further for not good reason, we chose to ditch dry-run mode.
We can add it back later if there's any interest in it, but hopefully by then we'll be able to do it right: instantiate a Gina script object in-process, set up some test objects, run the script object, and verify that no changes were committed.
== Pre-implementation notes ==
The salient bit:
(20:18:00) bigjools: first question, do we need a dry run mode?
(20:18:14) bigjools: IOW, how does it help us?
(20:18:34) jtv: Well since young Will here had no idea it even existed, I was wondering whether you might know the answer.
(20:19:00) bigjools: I don't I'm afraid, the Gina code has been barely touched in years, well before I started working on LP
== Implementation details ==
I fixed some lint as well. Sorry for the diff pollution.
== Tests ==
{{{
./bin/test -vvc lp.soyuz -t gina -t katie
}}}
== Demo and Q/A ==
We're getting quite experienced at doing gina test runs!
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
scripts/gina.py
lib/lp/
./scripts/gina.py
26: '_pythonpath' imported but unused
[1]
71 + raise AssertionError(
72 + "%s killed us on %s %s" % (len(q), query, args))
I know you didn't write it, but this error message makes little sense to me... any mileage in changing it in this branch, or does it make sufficient sense to those In The Know that it should remain untouched?