Merge lp:~jtv/launchpad/bug-733245 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jeroen T. Vermeulen | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12599 | ||||
Proposed branch: | lp:~jtv/launchpad/bug-733245 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
288 lines (+175/-8) 3 files modified
lib/lp/registry/model/distroseriesdifference.py (+1/-2) lib/lp/registry/scripts/populate_distroseriesdiff.py (+88/-4) lib/lp/registry/scripts/tests/test_populate_distroseriesdiff.py (+86/-2) |
||||
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-733245 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+53230@code.launchpad.net |
Commit message
[r=benji][bug=733245] Initialize DSD.base_version in populating script.
Description of the change
= Summary =
The DistroSeriesDif
== Proposed fix ==
Fire off a DBLoopTuner to fix up any DSDs for a freshly-populated DistroSeries. The work is likely to take long enough to warrant a DBLoopTuner; that way we know it won't cause undue stress on the backend.
If we enable the feature before the fixup is done, we'll start out with DSDs where it's impossible to request a diff. But that may be better than leaving the feature disabled until all the work is finished.
== Pre-implementation notes ==
This work is subject to more or less continuous discussion. In particular in this case, I discussed with StevenK.
== Implementation details ==
A new option --ignore-
Conversely, there is no mode to skip creation of DSDs; that part is fast and unintrusive enough to run multiple times — especially since it does not update or re-create existing DSDs. Just detecting which DSDs there should be takes a few seconds at worst.
== Tests ==
{{{
./bin/test -vvc lp.registry.
}}}
== Demo and Q/A ==
We'll run this on a full derived distroseries and check that some of the base_versions get updated. It won't be all, since it's not always possible to determine a usable base_version.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
Looks good.
Line 206 of lib/lp/ registry/ scripts/ populate_ distroseriesdif f.py (line
49 of the diff): I think you want to wrap temp_table in a call to
quote_identifier.
The use of the expression "3 - 1" in test_cutChunk_ one_cuts_ exactly_ one
is creative and increases the clarity of the test.