Merge lp:~jtaylor/ubuntu/raring/gnome-games/lp-995281 into lp:ubuntu/raring/gnome-games

Proposed by Julian Taylor
Status: Merged
Merge reported by: Iain Lane
Merged at revision: not available
Proposed branch: lp:~jtaylor/ubuntu/raring/gnome-games/lp-995281
Merge into: lp:ubuntu/raring/gnome-games
Diff against target: 42 lines (+24/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix-glines-crash.patch (+16/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~jtaylor/ubuntu/raring/gnome-games/lp-995281
Reviewer Review Type Date Requested Status
Iain Lane Disapprove
Ubuntu branches Pending
Review via email: mp+141286@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Thanks. The change looks fine but we use an ubuntu-desktop branch for this package - lp:~ubuntu-dekstop/gnome-games/ubuntu. I'll merge it there for you.

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-11-14 15:23:28 +0000
+++ debian/changelog 2012-12-26 19:19:29 +0000
@@ -1,3 +1,10 @@
1gnome-games (1:3.6.1-0ubuntu3) raring; urgency=low
2
3 * fix-glines-crash.patch:
4 fix glines crash on startup (LP: #995281)
5
6 -- Julian Taylor <jtaylor@ubuntu.com> Wed, 26 Dec 2012 19:42:38 +0100
7
1gnome-games (1:3.6.1-0ubuntu2) raring; urgency=low8gnome-games (1:3.6.1-0ubuntu2) raring; urgency=low
29
3 * Remove obsolete libgstreamer0.10-dev BD. 10 * Remove obsolete libgstreamer0.10-dev BD.
411
=== added file 'debian/patches/fix-glines-crash.patch'
--- debian/patches/fix-glines-crash.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/fix-glines-crash.patch 2012-12-26 19:19:29 +0000
@@ -0,0 +1,16 @@
1Description: prevent draw before preview is initinialized
2Origin: upstream bug
3Bug-Ubuntu: https://launchpad.net/bugs/995281
4Bug: https://bugzilla.gnome.org/show_bug.cgi?id=675628
5
6--- a/glines/src/glines.c
7+++ b/glines/src/glines.c
8@@ -443,7 +443,7 @@
9
10 for (i = 0; i < MAXNPIECES; i++) {
11
12- if (i < npieces)
13+ if (i < npieces && preview[i] > 0 )
14 pattern = cairo_pattern_create_for_surface (preview_surfaces[preview[i] - 1]);
15 else
16 pattern = cairo_pattern_create_for_surface (blank_preview_surface);
017
=== modified file 'debian/patches/series'
--- debian/patches/series 2012-11-06 10:56:12 +0000
+++ debian/patches/series 2012-12-26 19:19:29 +0000
@@ -1,1 +1,2 @@
102_desktop-path.patch102_desktop-path.patch
2fix-glines-crash.patch

Subscribers

People subscribed via source and target branches

to all changes: