Merge lp:~jsjgruber/ubuntu/oneiric/couchdb/couchdb.fix780972.r1039345 into lp:ubuntu/oneiric/couchdb
Proposed by
John S. Gruber
Status: | Rejected |
---|---|
Rejected by: | Stéphane Graber |
Proposed branch: | lp:~jsjgruber/ubuntu/oneiric/couchdb/couchdb.fix780972.r1039345 |
Merge into: | lp:ubuntu/oneiric/couchdb |
Diff against target: |
139 lines (+48/-32) 6 files modified
debian/changelog (+6/-0) src/erlang-oauth/oauth.app.in (+1/-1) src/erlang-oauth/oauth_hmac_sha1.erl (+1/-1) src/erlang-oauth/oauth_http.erl (+1/-1) src/erlang-oauth/oauth_plaintext.erl (+1/-1) src/erlang-oauth/oauth_uri.erl (+38/-28) |
To merge this branch: | bzr merge lp:~jsjgruber/ubuntu/oneiric/couchdb/couchdb.fix780972.r1039345 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey (community) | Disapprove | ||
Ubuntu branches | Pending | ||
Review via email: mp+74677@code.launchpad.net |
Description of the change
Proposed fix for LP: #780972, cherry picking from couchdb upstream svn r1039345.
Test build is in ppa:jsjgruber/ppa couchdb -- 1.0.1-0ubuntu17
i386 build log is at: https:/
to test use the command:
python -c "from desktopcouch.
Which should return without a traceback. The bug causes this to produce an unauthorized exception.
To post a comment you must log in.
Unmerged revisions
- 56. By John S. Gruber
-
Backport svn r1039345 from 1.0.3., fixing LP: #780972.
I'm voting my disapproval of this branch, not because I think the patch is bad, but because of how it is applied. Patches need to be files under debian/patches/ (like all the other patches in this package), and not direct changes in the tree. You also should not include your PPA ~version piece in the changelog version string for an upload into Ubuntu proper.
Since it was quick to do, I've went ahead and made another branch and proposed it, by making the changes into a proper patch, and tweaking the changelog entry, while still properly attributing the fix to you. It is at https:/ /code.launchpad .net/~dobey/ ubuntu/ oneiric/ couchdb/ fix-780972/ +merge/ 75238
Thanks.