Merge lp:~josharenson/indicator-sound/fix_mute_notifications into lp:indicator-sound/15.04

[Josh Arenson]

  Allow unchanged volume events if volume is 0.0 || 1.0

  Fixes lp:1421396

* Ensure the project compiles and the test suite executes without error
  It does, they do.

* Ensure that non-obvious code has comments explaining it
  Added comment

* If the change works on specific profiles, please include those in the merge description.
  N/A

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:477
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/213/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-amd64-ci/40
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/40
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-vivid-armhf-ci/40/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/213/rebuild

review: Approve (continuous-integration)

[Ted Gould (ted)]

Hi, thanks for the contribution. The code here that you modified was actually just a quick fix and is in the process of being dropped (as soon as it works through the machinery). If you're curious you can see the branch that fixes it, you can grab one of the debs there if you want it fixed on your device right away.

https://code.launchpad.net/~ted/indicator-sound/volume-reason/+merge/250042

review: Disapprove

[Josh Arenson (josharenson)]

Ah cool, I was a tad uneasy about my change anyway, just in case there was a weird usecase I missed. Yours should handle everything nicely. Thanks for updating the bug.

Unmerged revisions

477. By Josh Arenson on 2015-02-19

Allow unchanged volume events if volume is 0.0 || 1.0

Fixes lp:1421396

=== modified file 'src/service.vala'
--- src/service.vala	2015-02-05 14:52:58 +0000
+++ src/service.vala	2015-02-19 17:56:54 +0000
@@ -292,12 +292,16 @@
 		var oldvolume = this.last_volume_notification;
 		this.last_volume_notification = volume_control.volume;
 
-		/* Suppress notifications of volume changes if it is because the 
+		/* Suppress notifications of volume changes if it is because the
 		   output stream changed. */
 		if (oldoutput != this.last_output_notification)
 			return;
-		/* Supress updates that don't change the value */
-		if (GLib.Math.fabs(oldvolume - this.last_volume_notification) < 0.01)
+
+        /* Supress updates that don't change the value unless they are muted or max.
+         * This allows the user to receive feedback if the device is already in a
+         * muted or maxed state.
+         */
+		if ((GLib.Math.fabs(oldvolume - this.last_volume_notification) < 0.01) && (this.last_volume_notification > 0.0) && (this.last_volume_notification < 1.0))
 			return;
 
 		var shown_action = actions.lookup_action ("indicator-shown") as SimpleAction;