Merge lp:~jonas-drange/ubuntu-system-settings/apn-no-overwrite-1415495-rtm into lp:ubuntu-system-settings/rtm-14.09
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ken VanDine | ||||
Approved revision: | 1006 | ||||
Merged at revision: | 1006 | ||||
Proposed branch: | lp:~jonas-drange/ubuntu-system-settings/apn-no-overwrite-1415495-rtm | ||||
Merge into: | lp:ubuntu-system-settings/rtm-14.09 | ||||
Diff against target: |
130 lines (+42/-36) 1 file modified
plugins/cellular/PageChooseApn.qml (+42/-36) |
||||
To merge this branch: | bzr merge lp:~jonas-drange/ubuntu-system-settings/apn-no-overwrite-1415495-rtm | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ken VanDine | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+254129@code.launchpad.net |
Commit message
[cellular] apn page does not overwrite empty, provisioned contexts
Description of the change
What changed:
The current APN page made the assumption that an empty internet context/APN was really a recently added custom context/APNs (by the user). I have made this logic more precise by using a temporary event handler on ConnectionManager's contextAdded.
How to test:
Note: If you have special a special APN configuration, please back up the gprs file at /var/lib/
1. Stop ofono (sudo service ofono stop)
2. Edit /var/lib/
3. Start ofono (sudo service ofono start)
Note: If you have a krillin device, you need to set env vars to start ofono.
sudo service ofono start OFONO_RIL_
Note: If you have an arale device, you just need:
sudo service ofono start OFONO_RIL_
4. Wait 5 secs. Confirm that the output of /usr/share/
5. Enter the APN page
6. Add a custom context/APN and confirm it is not overwriting anything; or, that the output of $ /usr/share/
[1] https:/
[2] http://
PASSED: Continuous integration, rev:1006 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- rtm-14. 09-ci/71/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- 14.09-touch/ 50 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- rtm-14. 09-14.09- armhf-ci/ 72 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- rtm-14. 09-14.09- armhf-ci/ 72/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- 14.09-mako/ 50 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- 14.09-armhf/ 50 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- 14.09-armhf/ 50/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 19160
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- system- settings- rtm-14. 09-ci/71/ rebuild
http://