Merge ~jk0ne/charm-k8s-discourse/+git/discourse-k8s-image-builder:master into ~discourse-charmers/charm-k8s-discourse/+git/discourse-k8s-image-builder:master

Proposed by Jay Kuri
Status: Merged
Approved by: Tom Haddon
Approved revision: c6c66444d0d41627b2b3bb8d92753e73a21e1e50
Merged at revision: 43450e9dc5d7da4a0ff94d030707212645223083
Proposed branch: ~jk0ne/charm-k8s-discourse/+git/discourse-k8s-image-builder:master
Merge into: ~discourse-charmers/charm-k8s-discourse/+git/discourse-k8s-image-builder:master
Diff against target: 42 lines (+4/-7)
3 files modified
scripts/app_launch (+1/-4)
scripts/assets/discourse.conf.tmpl (+1/-1)
scripts/pod_start (+2/-2)
Reviewer Review Type Date Requested Status
Joel Sing (community) +1 Approve
Canonical IS Reviewers Pending
Review via email: mp+387226@code.launchpad.net

Commit message

use CONTAINER_APP_NAME in pod-setup exit status messaging

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Joel Sing (jsing) wrote :

LGTM

review: Approve (+1)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 43450e9dc5d7da4a0ff94d030707212645223083

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/scripts/app_launch b/scripts/app_launch
index 87f7166..0beae97 100755
--- a/scripts/app_launch
+++ b/scripts/app_launch
@@ -4,10 +4,7 @@ cd ${CONTAINER_APP_ROOT}/app
44
5export RAILS_ENV=${DISCOURSE_RAILS_ENVIRONMENT:-production}5export RAILS_ENV=${DISCOURSE_RAILS_ENVIRONMENT:-production}
6export UNICORN_BIND_ALL=0.0.0.06export UNICORN_BIND_ALL=0.0.0.0
77export UNICORN_SIDEKIQS=1
8if [ "${DISCOURSE_ENABLE_LOCAL_SIDEKIQ}" == "true" ]; then
9 export UNICORN_SIDEKIQS=1
10fi
118
12# Putting the tail's in the background gets the various logs outputting to9# Putting the tail's in the background gets the various logs outputting to
13# stdout. The sed allows us to distinguish where a given log line comes form.10# stdout. The sed allows us to distinguish where a given log line comes form.
diff --git a/scripts/assets/discourse.conf.tmpl b/scripts/assets/discourse.conf.tmpl
index 4cc13b9..f1e2270 100644
--- a/scripts/assets/discourse.conf.tmpl
+++ b/scripts/assets/discourse.conf.tmpl
@@ -1,6 +1,6 @@
1hostname = $DISCOURSE_HOSTNAME 1hostname = $DISCOURSE_HOSTNAME
2developer_emails = $DISCOURSE_DEVELOPER_EMAILS2developer_emails = $DISCOURSE_DEVELOPER_EMAILS
3serve_static_assets = $DISCOURSE_SERVE_STATIC_ASSETS 3serve_static_assets = true
4db_host = $DISCOURSE_POSTGRES_HOST 4db_host = $DISCOURSE_POSTGRES_HOST
5db_username = $DISCOURSE_POSTGRES_USERNAME5db_username = $DISCOURSE_POSTGRES_USERNAME
6db_password = $DISCOURSE_POSTGRES_PASSWORD6db_password = $DISCOURSE_POSTGRES_PASSWORD
diff --git a/scripts/pod_start b/scripts/pod_start
index 30b80c2..fd3d95f 100755
--- a/scripts/pod_start
+++ b/scripts/pod_start
@@ -20,9 +20,9 @@ echo "Pod setup starting..."
20SETUP_EXIT=$?20SETUP_EXIT=$?
2121
22if [ $SETUP_EXIT -eq 0 ]; then22if [ $SETUP_EXIT -eq 0 ]; then
23 echo "Pod setup completed successfully."23 echo "${CONTAINER_APP_NAME} setup completed successfully."
24else24else
25 echo "Pod setup failed with exit code: " $SETUP_EXIT25 echo "${CONTAINER_APP_NAME} setup failed with exit code: " $SETUP_EXIT
26fi26fi
2727
2828

Subscribers

People subscribed via source and target branches