Merge lp:~jfb-tempo-consulting/unifield-web/US-4786 into lp:~jfb-tempo-consulting/unifield-web/jfb-int

Proposed by jftempo
Status: Merged
Merged at revision: 4927
Proposed branch: lp:~jfb-tempo-consulting/unifield-web/US-4786
Merge into: lp:~jfb-tempo-consulting/unifield-web/jfb-int
Diff against target: 36 lines (+11/-1)
2 files modified
addons/openerp/static/javascript/o2m.js (+9/-1)
addons/openerp/widgets/form/_form.py (+2/-0)
To merge this branch: bzr merge lp:~jfb-tempo-consulting/unifield-web/US-4786
Reviewer Review Type Date Requested Status
jftempo Pending
Review via email: mp+352875@code.launchpad.net
To post a comment you must log in.
4924. By jftempo

US-4786 [FIX] o2m in form mode fix readonly switch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/openerp/static/javascript/o2m.js'
--- addons/openerp/static/javascript/o2m.js 2018-01-29 16:36:51 +0000
+++ addons/openerp/static/javascript/o2m.js 2018-08-10 10:10:33 +0000
@@ -198,10 +198,18 @@
198 if (readonly) {198 if (readonly) {
199 jQuery('table.one2many[id$="'+this.name+'"]').addClass('m2o_readonly');199 jQuery('table.one2many[id$="'+this.name+'"]').addClass('m2o_readonly');
200 if(btn){btn.style.display='none';}200 if(btn){btn.style.display='none';}
201 201
202 MochiKit.Base.map(function (el) {el.style.visibility='hidden';},MochiKit.Selector.findChildElements(grid,['.selector']));202 MochiKit.Base.map(function (el) {el.style.visibility='hidden';},MochiKit.Selector.findChildElements(grid,['.selector']));
203 edit.value= 0;203 edit.value= 0;
204204
205 if (!grid) {
206 var grid=MochiKit.DOM.getElement('_o2m_'+this.name);
207 if (grid) {
208 MochiKit.Base.map(function (el) {form_setReadonly('', el, readonly)}, MochiKit.Selector.findChildElements(grid,['input[kind]']));
209 MochiKit.Base.map(function (el) {form_setReadonly('', el, readonly)}, MochiKit.Selector.findChildElements(grid,['select[kind]']));
210 MochiKit.Base.map(function (el) {el.style.visibility='hidden';},MochiKit.Selector.findChildElements(grid,['a.button-a']));
211 }
212 }
205 // Not disabling clicks on line dynamically (in browser) to be213 // Not disabling clicks on line dynamically (in browser) to be
206 // consistent with previous behaviors. In many cases (e.g. FO, SI,214 // consistent with previous behaviors. In many cases (e.g. FO, SI,
207 // ...) we want o2m to be readonly (no New button) but the lines215 // ...) we want o2m to be readonly (no New button) but the lines
208216
=== modified file 'addons/openerp/widgets/form/_form.py'
--- addons/openerp/widgets/form/_form.py 2018-05-15 07:28:21 +0000
+++ addons/openerp/widgets/form/_form.py 2018-08-10 10:10:33 +0000
@@ -196,6 +196,8 @@
196 attrs['attrs'] = str(widget.attributes)196 attrs['attrs'] = str(widget.attributes)
197 attrs['widget'] = widget.name197 attrs['widget'] = widget.name
198198
199 if widget.__class__.__name__ == 'O2M' and widget.view_type == 'form':
200 attrs['id'] = widget.name
199 if not isinstance(widget, (Char, Frame, Float, DateTime, Integer, Selection, Notebook, Separator, NewLine, Label)):201 if not isinstance(widget, (Char, Frame, Float, DateTime, Integer, Selection, Notebook, Separator, NewLine, Label)):
200 from openerp.widgets.search import Filter202 from openerp.widgets.search import Filter
201 if self.is_search \203 if self.is_search \

Subscribers

People subscribed via source and target branches

to all changes: