Merge lp:~jeremywootten/pantheon-files/fix-1456202-multiple-operations-one-view into lp:~elementary-apps/pantheon-files/trunk
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Adam Bieńkowski | ||||
Approved revision: | 2520 | ||||
Merged at revision: | 2573 | ||||
Proposed branch: | lp:~jeremywootten/pantheon-files/fix-1456202-multiple-operations-one-view | ||||
Merge into: | lp:~elementary-apps/pantheon-files/trunk | ||||
Diff against target: |
78 lines (+3/-19) 1 file modified
src/View/AbstractDirectoryView.vala (+3/-19) |
||||
To merge this branch: | bzr merge lp:~jeremywootten/pantheon-files/fix-1456202-multiple-operations-one-view | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Bieńkowski (community) | code | Approve | |
Dieter Debast (community) | Approve | ||
Review via email: mp+319354@code.launchpad.net |
Commit message
remove the blocks on carrying out more than one copy/cut/paste operation or trash/delete operation on the same view at the same time
Description of the change
This branch removes the blocks on carrying out more than one copy/cut/paste operation or trash/delete operation on the same view at the same time.
While these blocks were presumably originally put in place in the interests of stability, removing has not immediately revealed any regressions.
TO TEST (E.G.):
1: Carry out a slow file operation e.g. copying a fairly large folder in place on a remote filesystem or USB stick.
2: Perform another similar copy paste operation on another (or the same) fairly large folder in the same view before the first operation completes. The destination must be the same open view.
In trunk this is not possible. In this branch, both operations run and complete successfully.
Note: With these blocks removed it is possible to do things like deleting the folder which is being copied while the copy is in progress. However, this does not cause a crash - it just causes the copy operation to fail.
This branch needs careful testing with a range of simultaneous operations on the same view to ensure stability is maintained.
I can't find any problems on this branch, unless I forgot to test something (but hopefully not). I tried a variety of copying, cutting, deleting and renaming and it doesn't crash or behave in a strange way.