Merge lp:~jelmer/launchpad/653720-failedtoupload into lp:launchpad
Proposed by
Jelmer Vernooij
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jelmer Vernooij | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 11741 | ||||
Proposed branch: | lp:~jelmer/launchpad/653720-failedtoupload | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
23 lines (+1/-1) 2 files modified
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+0/-1) lib/lp/archiveuploader/uploadprocessor.py (+1/-0) |
||||
To merge this branch: | bzr merge lp:~jelmer/launchpad/653720-failedtoupload | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julian Edwards (community) | release-critical | Approve | |
Michael Nelson (community) | code | Approve | |
Steve Kowalik (community) | code* | Approve | |
Review via email: mp+37833@code.launchpad.net |
Commit message
Commit after changing build status in the upload processor.
Description of the change
commit() after the build status is being set to FAILEDTOUPLOAD in the upload processor.
At the moment there is no commit so the build status doesn't make it to the database since the uploadprocessor aborts any pending transactions. This means that any failed uploads will be stuck in UPLOADING status even though they have already failed.
To post a comment you must log in.
Thanks for the simple change! My only issue with the branch is the two changes to the result = self.processCha ngesFile( ) call, which is longer than 73 characters.