Merge lp:~jelmer/brz/supports-random-access into lp:brz

[Jelmer Vernooij]

Add a supports_random_access attribute to repository.

Add a supports_random_access attribute to repository.

This indicates where the repository instance can be used for random access,
e.g. retrieving specific revisions. This is useful to skip such actions on e.g.
remote git repositories, which only support bulk fetching and pushing.

[Martin Packman (gz)]

No content in this branch.

[Martin Packman (gz)]

Thanks!

review: Approve

=== modified file 'breezy/git/remote.py'
--- breezy/git/remote.py	2019-01-19 15:46:15 +0000
+++ breezy/git/remote.py	2019-02-02 11:29:27 +0000
@@ -828,6 +828,8 @@
 
 class RemoteGitRepository(GitRepository):
 
+    supports_random_access = False
+
     @property
     def user_url(self):
         return self.control_url
 
=== modified file 'breezy/repository.py'
--- breezy/repository.py	2019-01-01 23:40:59 +0000
+++ breezy/repository.py	2019-02-02 11:29:27 +0000
@@ -256,6 +256,10 @@
     base class for most Bazaar repositories.
     """
 
+    # Does this repository implementation support random access to
+    # items in the tree, or just bulk fetching/pushing of data?
+    supports_random_access = True
+
     def abort_write_group(self, suppress_errors=False):
         """Commit the contents accrued within the current write group.
 
 
=== modified file 'breezy/tests/per_repository/test_repository.py'
--- breezy/tests/per_repository/test_repository.py	2018-11-21 03:20:30 +0000
+++ breezy/tests/per_repository/test_repository.py	2019-02-02 11:29:27 +0000
@@ -73,6 +73,11 @@
         repo = self.make_repository('repo')
         self.assertIn(getattr(repo._format, attribute), allowed_values)
 
+    def assertRepositoryAttribute(self, attribute, allowed_values):
+        """Assert that the repo has an attribute 'attribute'."""
+        repo = self.make_repository('repo')
+        self.assertIn(getattr(repo, attribute), allowed_values)
+
     def test_attribute_fast_deltas(self):
         """Test the format.fast_deltas attribute."""
         self.assertFormatAttribute('fast_deltas', (True, False))
@@ -117,6 +122,9 @@
         self.assertFormatAttribute('revision_graph_can_have_wrong_parents',
                                    (True, False))
 
+    def test_attribute_format_supports_random_access(self):
+        self.assertRepositoryAttribute('supports_random_access', (True, False))
+
     def test_attribute_format_supports_setting_revision_ids(self):
         self.assertFormatAttribute('supports_setting_revision_ids',
                                    (True, False))