Merge lp:~jdstrand/powerd/powerd-lp1296415 into lp:powerd

Proposed by Jamie Strandboge
Status: Rejected
Rejected by: Jamie Strandboge
Proposed branch: lp:~jdstrand/powerd/powerd-lp1296415
Merge into: lp:powerd
Diff against target: 70 lines (+27/-0)
6 files modified
debian/control (+1/-0)
debian/dirs (+1/-0)
debian/install (+1/-0)
debian/rules (+4/-0)
debian/upstart (+4/-0)
debian/usr.bin.powerd (+16/-0)
To merge this branch: bzr merge lp:~jdstrand/powerd/powerd-lp1296415
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+224366@code.launchpad.net

Commit message

  * add lenient AppArmor profile to allow connecting to ofono (LP: #1296415)
    - add debian/usr.bin.powerd
    - debian/control: Build-Depends on dh-apparmor
    - debian/rules: update override_dh_installdeb to use dh_apparmor
    - debian/powerd.dirs: add etc/apparmor.d
    - debian/powerd.install: install profile in to place
    - debian/upstart: update to load the AppArmor profile

Description of the change

  * add lenient AppArmor profile to allow connecting to ofono (LP: #1296415)
    - add debian/usr.bin.powerd
    - debian/control: Build-Depends on dh-apparmor
    - debian/rules: update override_dh_installdeb to use dh_apparmor
    - debian/powerd.dirs: add etc/apparmor.d
    - debian/powerd.install: install profile in to place
    - debian/upstart: update to load the AppArmor profile

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~jdstrand/powerd/powerd-lp1296415 updated
133. By Jamie Strandboge

debian/usr.bin.powerd: more closely mimic confined with exec transitions

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Rejecting for now since we won't be implementing this (see bug description).

Unmerged revisions

133. By Jamie Strandboge

debian/usr.bin.powerd: more closely mimic confined with exec transitions

132. By Jamie Strandboge

revert change to debian/changelog-- let autolanding handle it

131. By Jamie Strandboge

* add lenient AppArmor profile to allow connecting to ofono (LP: #1296415)
  - add debian/usr.bin.powerd
  - debian/control: Build-Depends on dh-apparmor
  - debian/rules: update override_dh_installdeb to use dh_apparmor
  - debian/powerd.dirs: add etc/apparmor.d
  - debian/powerd.install: install profile in to place
  - debian/upstart: update to load the AppArmor profile

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2014-05-29 06:53:15 +0000
+++ debian/control 2014-06-24 22:23:58 +0000
@@ -13,6 +13,7 @@
13 libupower-glib-dev,13 libupower-glib-dev,
14 uuid-dev,14 uuid-dev,
15 libhardware-dev (>= 0.1.0+git20131207+e452e83-0ubuntu12),15 libhardware-dev (>= 0.1.0+git20131207+e452e83-0ubuntu12),
16 dh-apparmor,
16Standards-Version: 3.9.417Standards-Version: 3.9.4
17Homepage: https://launchpad.net/powerd18Homepage: https://launchpad.net/powerd
18# If you aren't a member of ~phablet-team but need to upload packaging changes,19# If you aren't a member of ~phablet-team but need to upload packaging changes,
1920
=== added file 'debian/dirs'
--- debian/dirs 1970-01-01 00:00:00 +0000
+++ debian/dirs 2014-06-24 22:23:58 +0000
@@ -0,0 +1,1 @@
1etc/apparmor.d
02
=== modified file 'debian/install'
--- debian/install 2013-05-22 17:35:03 +0000
+++ debian/install 2014-06-24 22:23:58 +0000
@@ -1,1 +1,2 @@
1debian/powerd.conf etc/dbus-1/system.d/1debian/powerd.conf etc/dbus-1/system.d/
2debian/usr.bin.powerd etc/apparmor.d
23
=== modified file 'debian/rules'
--- debian/rules 2013-06-04 06:19:10 +0000
+++ debian/rules 2014-06-24 22:23:58 +0000
@@ -10,3 +10,7 @@
1010
11override_dh_install:11override_dh_install:
12 dh_install --fail-missing12 dh_install --fail-missing
13
14override_dh_installdeb:
15 dh_apparmor --profile-name=usr.bin.powerd -ppowerd
16 dh_installdeb
1317
=== modified file 'debian/upstart'
--- debian/upstart 2013-08-14 11:07:09 +0000
+++ debian/upstart 2014-06-24 22:23:58 +0000
@@ -8,4 +8,8 @@
8#uncomment the line below to enable debugging8#uncomment the line below to enable debugging
9#env POWERD_DEBUG=19#env POWERD_DEBUG=1
1010
11pre-start script
12 /lib/init/apparmor-profile-load usr.bin.powerd
13end script
14
11exec /usr/bin/powerd15exec /usr/bin/powerd
1216
=== added file 'debian/usr.bin.powerd'
--- debian/usr.bin.powerd 1970-01-01 00:00:00 +0000
+++ debian/usr.bin.powerd 2014-06-24 22:23:58 +0000
@@ -0,0 +1,16 @@
1#include <tunables/global>
2
3# Permissive profile to have profile name to limit access to ofonod (LP: #1296415)
4/usr/bin/powerd (attach_disconnected) {
5 capability,
6 mount,
7 remount,
8 umount,
9 network,
10 / rwkl,
11 /** rwlkm,
12 /** pix,
13 dbus,
14 signal,
15 ptrace,
16}

Subscribers

People subscribed via source and target branches