Merge lp:~jamesodhunt/upstart/bypass-quiesce-logic-for-pid1 into lp:upstart

Proposed by James Hunt
Status: Merged
Merged at revision: 1535
Proposed branch: lp:~jamesodhunt/upstart/bypass-quiesce-logic-for-pid1
Merge into: lp:upstart
Diff against target: 36 lines (+9/-1)
2 files modified
ChangeLog (+5/-0)
init/event.c (+4/-1)
To merge this branch: bzr merge lp:~jamesodhunt/upstart/bypass-quiesce-logic-for-pid1
Reviewer Review Type Date Requested Status
Upstart Reviewers Pending
Review via email: mp+188089@code.launchpad.net

Description of the change

* init/event.c: event_pending_handle_jobs(): Don't re-iterate job classes unless quiescing.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ChangeLog'
--- ChangeLog 2013-09-26 16:33:07 +0000
+++ ChangeLog 2013-09-27 16:07:00 +0000
@@ -1,5 +1,10 @@
12013-09-26 James Hunt <james.hunt@ubuntu.com>12013-09-26 James Hunt <james.hunt@ubuntu.com>
22
3 * init/event.c: event_pending_handle_jobs(): Don't re-iterate job classes
4 unless quiescing.
5
62013-09-26 James Hunt <james.hunt@ubuntu.com>
7
3 * init/event.c: event_pending_handle_jobs(): Force quiesce when all job8 * init/event.c: event_pending_handle_jobs(): Force quiesce when all job
4 instances have finished to speed session shutdown.9 instances have finished to speed session shutdown.
5 * init/job_process.c: job_process_jobs_running(): Only consider job10 * init/job_process.c: job_process_jobs_running(): Only consider job
611
=== modified file 'init/event.c'
--- init/event.c 2013-09-26 16:33:07 +0000
+++ init/event.c 2013-09-27 16:07:00 +0000
@@ -436,6 +436,9 @@
436 }436 }
437 }437 }
438438
439 if (! quiesce_in_progress ())
440 return;
441
439 /* Determine if any job instances remain */442 /* Determine if any job instances remain */
440 NIH_HASH_FOREACH_SAFE (job_classes, iter) {443 NIH_HASH_FOREACH_SAFE (job_classes, iter) {
441 JobClass *class = (JobClass *)iter;444 JobClass *class = (JobClass *)iter;
@@ -450,7 +453,7 @@
450 }453 }
451454
452 /* If no instances remain, force quiesce to finish */455 /* If no instances remain, force quiesce to finish */
453 if (empty && quiesce_in_progress ())456 if (empty)
454 quiesce_complete ();457 quiesce_complete ();
455}458}
456459

Subscribers

People subscribed via source and target branches