Merge lp:~jamesh/thumbnailer/use-thumbnailer-interface into lp:thumbnailer/devel

[James Henstridge]

Switch to the specialised "thumbnailer" snapd interface.

Switch to the specialised "thumbnailer" snapd interface.

I also moved snapcraft.yaml to snap/snapcraft.yaml, which seems to be the preferred location now. You should still run "snapcraft" at the root of the branch.

This interface is only available in the upcoming snapd 2.23, which will hopefully be released soon. It might be worth delaying merging this until it is out.

[unity-api-1-bot (unity-api-1-bot)]

PASSED: Continuous integration, rev:374
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/37/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1697
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1704
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1479/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/37/rebuild

review: Approve (continuous-integration)

[Michi Henning (michihenning)]

Interface has merged into snapd now, so all good.

review: Approve

=== added directory 'snap'
=== renamed file 'snapcraft.yaml' => 'snap/snapcraft.yaml'
--- snapcraft.yaml	2017-02-08 06:54:23 +0000
+++ snap/snapcraft.yaml	2017-02-20 07:29:38 +0000
@@ -11,9 +11,7 @@
 
 slots:
   thumbnailer:
-    interface: dbus
-    name: com.canonical.Thumbnailer
-    bus: session
+    interface: thumbnailer
 
 plugs:
   platform:
@@ -21,12 +19,8 @@
     content: ubuntu-app-platform1
     target: ubuntu-app-platform
     default-provider: ubuntu-app-platform
-  network-manager:
-    interface: network-manager
   thumbnails:
-    interface: dbus
-    name: com.canonical.Thumbnailer
-    bus: session
+    interface: thumbnailer
 
 apps:
   thumbnailer-service:
@@ -37,9 +31,6 @@
     plugs:
       - platform
       - network
-      # TODO: This grants more privileges than we really need but, without this, apparmor
-      # denies access.
-      - network-manager
       # TODO: The gsettings interface currently does not permit reading.
       # See https://bugs.launchpad.net/snappy/+bug/1600154
       # For now, the service uses default settings because it's gsettings lookups fail.