Merge lp:~james-w/tarmac/utf8 into lp:tarmac

[James Westby]

Force output to utf-8

This is a bugfix we used in CA when we were seeing failures because of some
test output causing decode errors.

Those errors probably indicate an environment configuration issue, but this
change gives the user some indication of what was going on, rather than just
a UnicodeDecodeError traceback.

(from the u1 fork)

[James Westby (james-w)]

This was also proposed in https://code.launchpad.net/~jameinel/tarmac/non_ascii-750930/+merge/73831 (with tests)

[Paul Hummer (rockstar)]

review: Approve

[Paul Hummer (rockstar)]

The prerequisite lp:~james-w/tarmac/setsid has not yet been merged into lp:tarmac.

[dobey (dobey)]

Duplicate of https://code.launchpad.net/~jameinel/tarmac/non_ascii-750930/+merge/73831 and missing a test.

review: Disapprove

Unmerged revisions

421. By James Westby on 2013-01-31

Merged setsid into utf8.

420. By James Westby on 2013-01-24

Drop unneeded change.

419. By James Westby on 2013-01-24

Merged setsid into utf8.

418. By James Westby on 2013-01-24

Merged branch-tree-properties into utf8.

417. By James Westby on 2013-01-23

Merge trunk.

416. By James Westby on 2013-01-23

Merge trunk.

415. By James Westby on 2012-12-18

Decode stderr/stdout from the command, ignoring errors.

We were seeing UnicodeDecodeErrors in Jenkins on occaision, so
we changed the code to be more robust, and to discard anything
that couldn't be decoded from utf-8.

414. By Sidnei da Silva on 2012-09-11

- Disable lightweight checkouts

413. By Sidnei da Silva on 2012-09-05

- Oops, target can be None here.

412. By Sidnei da Silva on 2012-09-05

- Die locks die

=== modified file 'tarmac/plugins/command.py'
--- tarmac/plugins/command.py	2013-02-01 17:16:21 +0000
+++ tarmac/plugins/command.py	2013-02-01 17:16:21 +0000
@@ -185,7 +185,7 @@
                    u'%(output)s') % {
             'source': self.proposal.source_branch.display_name,
             'target': self.proposal.target_branch.display_name,
-            'output': u'\n'.join([stdout_value, stderr_value]),
+            'output': u'\n'.join([stdout_value.decode('utf-8', 'ignore'), stderr_value.decode('utf-8', 'ignore')]),
             }
         raise VerifyCommandFailed(message, comment)