Launchpad itself

Merge lp:~jameinel/launchpad/lp-serve-cleanup into lp:launchpad

  1. lp-serve-cleanup
  2. Merge into devel
Proposed by John A Meinel
Status: Merged
Approved by: Jonathan Lange
Approved revision: no longer in the source branch.
Merged at revision: 11262
Proposed branch: lp:~jameinel/launchpad/lp-serve-cleanup
Merge into: lp:launchpad
Diff against target: 32 lines (+4/-4)
1 file modified
lib/lp/services/sshserver/tests/test_session.py (+4/-4)
To merge this branch: bzr merge lp:~jameinel/launchpad/lp-serve-cleanup
Reviewer Review Type Date Requested Status
Jonathan Lange (community) Approve
Review via email: mp+30542@code.launchpad.net

Commit message

Comment cleanup from "ExecOnlySession" to "DoNothingSession"

Description of the change

This is a rather minor cleanup, just of comments, etc. The tests in question were copied from elsewhere but are testing the DoNothingSession but claimed to be testing the ExecOnlySession.

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/services/sshserver/tests/test_session.py'
--- lib/lp/services/sshserver/tests/test_session.py 2010-06-25 17:19:11 +0000
+++ lib/lp/services/sshserver/tests/test_session.py 2010-07-21 14:41:26 +0000
@@ -48,7 +48,7 @@
4848
4949
50class TestDoNothing(TestCase):50class TestDoNothing(TestCase):
51 """Tests for ExecOnlySession."""51 """Tests for DoNothingSession."""
5252
53 def setUp(self):53 def setUp(self):
54 super(TestDoNothing, self).setUp()54 super(TestDoNothing, self).setUp()
@@ -77,16 +77,16 @@
77 self.session.windowChanged, None)77 self.session.windowChanged, None)
7878
79 def test_providesISession(self):79 def test_providesISession(self):
80 # ExecOnlySession must provide ISession.80 # DoNothingSession must provide ISession.
81 self.failUnless(ISession.providedBy(self.session),81 self.failUnless(ISession.providedBy(self.session),
82 "ExecOnlySession doesn't implement ISession")82 "DoNothingSession doesn't implement ISession")
8383
84 def test_closedDoesNothing(self):84 def test_closedDoesNothing(self):
85 # closed is a no-op.85 # closed is a no-op.
86 self.assertEqual(None, self.session.closed())86 self.assertEqual(None, self.session.closed())
8787
88 def test_execCommandNotImplemented(self):88 def test_execCommandNotImplemented(self):
89 # ExecOnlySession.execCommand spawns the appropriate process.89 # DoNothingSession.execCommand spawns the appropriate process.
90 protocol = MockProcessTransport('bash')90 protocol = MockProcessTransport('bash')
91 command = 'cat /etc/hostname'91 command = 'cat /etc/hostname'
92 self.session.execCommand(protocol, command)92 self.session.execCommand(protocol, command)