Merge lp:~jameinel/bzr/2.1.0b4-win32-unsupported_encoding_commit_message into lp:bzr
Proposed by
John A Meinel
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~jameinel/bzr/2.1.0b4-win32-unsupported_encoding_commit_message |
Merge into: | lp:bzr |
Diff against target: |
32 lines (+4/-4) 1 file modified
bzrlib/tests/blackbox/test_commit.py (+4/-4) |
To merge this branch: | bzr merge lp:~jameinel/bzr/2.1.0b4-win32-unsupported_encoding_commit_message |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Approve | ||
bzr-core | Pending | ||
Review via email: mp+14603@code.launchpad.net |
To post a comment you must log in.
Another small update to get the test suite passing on windows. From the commit message:
test_unsupporte d_encoding_ commit_ message no longer applies for Windows.
We now parse a Unicode string directly, so it isn't really possible to pass
a non-ascii string that will fail to decode.
I'm slowly building these up into a separate 'win32 test suite' branch, but I figured it would be a lot easier to review them one-at-a-time.
Then if anything ends up being controversial, it doesn't have to block the rest of them.