Merge lp:~jameinel/bzr/1.16-abort-resume-aborts-start into lp:~bzr/bzr/trunk-old
Proposed by
John A Meinel
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~jameinel/bzr/1.16-abort-resume-aborts-start |
Merge into: | lp:~bzr/bzr/trunk-old |
Diff against target: | 15 lines |
To merge this branch: | bzr merge lp:~jameinel/bzr/1.16-abort-resume-aborts-start |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Bennetts | Approve | ||
Review via email: mp+6949@code.launchpad.net |
To post a comment you must log in.
This gives a cleaner test suite run on Windows.
Basically, Repository. resume_ write_group( ) internally _starts_ write_group( ) and then resumes the given tokens.
However, tokens can fail to be resumed, which leaves things in an intermediate state. Namely, the _start_write_group finished, but wasn't aborted. Which leaves open the NewPack.
I don't know if this ever matters in practice, but at least on Windows it causes resume_ aborted_ write_group( self):
def test_cannot_
To give cleanup stipple because we can't cleanup the working dir because of the open file handle.