Merge lp:~jamalta/unity/683241-recyclebin-icon into lp:unity
Proposed by
Jamal Fanaian
Status: | Merged |
---|---|
Approved by: | Alex Launi |
Approved revision: | no longer in the source branch. |
Merged at revision: | 675 |
Proposed branch: | lp:~jamalta/unity/683241-recyclebin-icon |
Merge into: | lp:unity |
Diff against target: |
110 lines (+72/-2) 2 files modified
src/TrashLauncherIcon.cpp (+65/-2) src/TrashLauncherIcon.h (+7/-0) |
To merge this branch: | bzr merge lp:~jamalta/unity/683241-recyclebin-icon |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Launi (community) | Approve | ||
Jason Smith | Pending | ||
Review via email: mp+42917@code.launchpad.net |
Description of the change
Changing the trash icon depending on whether the trash is empty or not.
To post a comment you must log in.
Looks good. The only comment I have is a formatting comment (which I'll fix, don't worry about it). When you create the trash monitor, the first param should be on the same line as the constructor, and then the other params aligned.