Merge lp:~intellectronica/launchpad/hot-bugs-summary into lp:launchpad

Proposed by Eleanor Berger
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~intellectronica/launchpad/hot-bugs-summary
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~intellectronica/launchpad/hot-bugs-summary
Reviewer Review Type Date Requested Status
Brad Crittenden (community) release-critical Approve
Henning Eggers (community) code Approve
Review via email: mp+12150@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Eleanor Berger (intellectronica) wrote :

This branch fixes the field used for the bug summary in the new 'hot bugs' listing on the bugs homepage for a project. It now uses bugtask.bug.title instead of bugtask.title (which is incorrect). I've also added a minimal pagetest which was missing.

Revision history for this message
Henning Eggers (henninge) wrote :

Good, quick, and easy fix. Thanks for improving test coverage!

Henning

review: Approve (code)
Revision history for this message
Brad Crittenden (bac) wrote :

Nice work Tom.

review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt'
--- lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt 2009-09-20 16:05:43 +0000
+++ lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt 2009-09-21 08:58:50 +0000
@@ -160,3 +160,19 @@
160 >>> print_bugtasks(anon_browser.contents)160 >>> print_bugtasks(anon_browser.contents)
161 5 Firefox install instructions should be complete161 5 Firefox install instructions should be complete
162 Critical New162 Critical New
163
164
165== Hot Bugs ==
166
167A listing of the 10 'hottest' bugs (currently simply the bugs most recently
168touched) is display to allow a quick overview of the project. For each bug we
169have the number, title, status, importance and the time since the last update.
170
171 >>> anon_browser.open('http://bugs.launchpad.dev/firefox')
172 >>> print extract_text(
173 ... find_tag_by_id(anon_browser.contents, 'hot-bugs'))
174 Summary Status Importance Last changed
175 #14 Firefox install... New Critical on 2006-07-14
176 #13 Reflow problems... New Medium on 2006-07-14
177 #2 Firefox does no... New Low on 2006-05-19
178
163179
=== modified file 'lib/lp/bugs/templates/bugtarget-bugs.pt'
--- lib/lp/bugs/templates/bugtarget-bugs.pt 2009-09-20 16:05:43 +0000
+++ lib/lp/bugs/templates/bugtarget-bugs.pt 2009-09-21 08:58:50 +0000
@@ -202,7 +202,7 @@
202 </td>202 </td>
203 <td>203 <td>
204 <a tal:attributes="href bugtask/fmt:url"204 <a tal:attributes="href bugtask/fmt:url"
205 tal:content="bugtask/title" />205 tal:content="bugtask/bug/title" />
206 </td>206 </td>
207 <td tal:attributes="class string:status${bugtask/status/name}"207 <td tal:attributes="class string:status${bugtask/status/name}"
208 tal:content="bugtask/status/title" />208 tal:content="bugtask/status/title" />