Merge lp:~indicator-applet-developers/indicator-appmenu/ubuntu into lp:~ubuntu-desktop/indicator-appmenu/ubuntu

Proposed by Ted Gould
Status: Rejected
Rejected by: Ken VanDine
Proposed branch: lp:~indicator-applet-developers/indicator-appmenu/ubuntu
Merge into: lp:~ubuntu-desktop/indicator-appmenu/ubuntu
Diff against target: 183 lines (+33/-31)
7 files modified
ChangeLog (+12/-0)
configure (+10/-10)
configure.ac (+2/-2)
debian/changelog (+8/-0)
debian/patches/double-ref-of-entry-label.patch (+0/-17)
debian/patches/series (+0/-1)
src/window-menus.c (+1/-1)
To merge this branch: bzr merge lp:~indicator-applet-developers/indicator-appmenu/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+79326@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ChangeLog'
--- ChangeLog 2011-09-29 15:24:51 +0000
+++ ChangeLog 2011-10-13 18:40:32 +0000
@@ -1,5 +1,17 @@
1# Generated by Makefile. Do not edit.1# Generated by Makefile. Do not edit.
22
32011-10-13 Ted Gould <ted@gould.cx>
4
5 0.3.2
6
72011-10-12 Ted Gould <ted@gould.cx>
8
9 Make sure to keep the ref on the label via sinking.
10
112011-10-05 Michael Terry <michael.terry@canonical.com>
12
13 don't double-ref entry->label
14
32011-09-29 Ted Gould <ted@gould.cx>152011-09-29 Ted Gould <ted@gould.cx>
416
5 0.3.117 0.3.1
618
=== modified file 'configure'
--- configure 2011-09-29 15:25:16 +0000
+++ configure 2011-10-13 18:40:32 +0000
@@ -1,6 +1,6 @@
1#! /bin/sh1#! /bin/sh
2# Guess values for system-dependent variables and create Makefiles.2# Guess values for system-dependent variables and create Makefiles.
3# Generated by GNU Autoconf 2.68 for indicator-appmenu 0.3.1.3# Generated by GNU Autoconf 2.68 for indicator-appmenu 0.3.2.
4#4#
5# Report bugs to <ted@canonical.com>.5# Report bugs to <ted@canonical.com>.
6#6#
@@ -572,8 +572,8 @@
572# Identity of this package.572# Identity of this package.
573PACKAGE_NAME='indicator-appmenu'573PACKAGE_NAME='indicator-appmenu'
574PACKAGE_TARNAME='indicator-appmenu'574PACKAGE_TARNAME='indicator-appmenu'
575PACKAGE_VERSION='0.3.1'575PACKAGE_VERSION='0.3.2'
576PACKAGE_STRING='indicator-appmenu 0.3.1'576PACKAGE_STRING='indicator-appmenu 0.3.2'
577PACKAGE_BUGREPORT='ted@canonical.com'577PACKAGE_BUGREPORT='ted@canonical.com'
578PACKAGE_URL=''578PACKAGE_URL=''
579579
@@ -1339,7 +1339,7 @@
1339 # Omit some internal or obsolete options to make the list less imposing.1339 # Omit some internal or obsolete options to make the list less imposing.
1340 # This message is too long to be a string in the A/UX 3.1 sh.1340 # This message is too long to be a string in the A/UX 3.1 sh.
1341 cat <<_ACEOF1341 cat <<_ACEOF
1342\`configure' configures indicator-appmenu 0.3.1 to adapt to many kinds of systems.1342\`configure' configures indicator-appmenu 0.3.2 to adapt to many kinds of systems.
13431343
1344Usage: $0 [OPTION]... [VAR=VALUE]...1344Usage: $0 [OPTION]... [VAR=VALUE]...
13451345
@@ -1410,7 +1410,7 @@
14101410
1411if test -n "$ac_init_help"; then1411if test -n "$ac_init_help"; then
1412 case $ac_init_help in1412 case $ac_init_help in
1413 short | recursive ) echo "Configuration of indicator-appmenu 0.3.1:";;1413 short | recursive ) echo "Configuration of indicator-appmenu 0.3.2:";;
1414 esac1414 esac
1415 cat <<\_ACEOF1415 cat <<\_ACEOF
14161416
@@ -1540,7 +1540,7 @@
1540test -n "$ac_init_help" && exit $ac_status1540test -n "$ac_init_help" && exit $ac_status
1541if $ac_init_version; then1541if $ac_init_version; then
1542 cat <<\_ACEOF1542 cat <<\_ACEOF
1543indicator-appmenu configure 0.3.11543indicator-appmenu configure 0.3.2
1544generated by GNU Autoconf 2.681544generated by GNU Autoconf 2.68
15451545
1546Copyright (C) 2010 Free Software Foundation, Inc.1546Copyright (C) 2010 Free Software Foundation, Inc.
@@ -1820,7 +1820,7 @@
1820This file contains any messages produced by compilers while1820This file contains any messages produced by compilers while
1821running configure, to aid debugging if configure makes a mistake.1821running configure, to aid debugging if configure makes a mistake.
18221822
1823It was created by indicator-appmenu $as_me 0.3.1, which was1823It was created by indicator-appmenu $as_me 0.3.2, which was
1824generated by GNU Autoconf 2.68. Invocation command line was1824generated by GNU Autoconf 2.68. Invocation command line was
18251825
1826 $ $0 $@1826 $ $0 $@
@@ -2641,7 +2641,7 @@
26412641
2642# Define the identity of the package.2642# Define the identity of the package.
2643 PACKAGE=indicator-appmenu2643 PACKAGE=indicator-appmenu
2644 VERSION=0.3.12644 VERSION=0.3.2
26452645
26462646
2647cat >>confdefs.h <<_ACEOF2647cat >>confdefs.h <<_ACEOF
@@ -13687,7 +13687,7 @@
13687# report actual input values of CONFIG_FILES etc. instead of their13687# report actual input values of CONFIG_FILES etc. instead of their
13688# values after options handling.13688# values after options handling.
13689ac_log="13689ac_log="
13690This file was extended by indicator-appmenu $as_me 0.3.1, which was13690This file was extended by indicator-appmenu $as_me 0.3.2, which was
13691generated by GNU Autoconf 2.68. Invocation command line was13691generated by GNU Autoconf 2.68. Invocation command line was
1369213692
13693 CONFIG_FILES = $CONFIG_FILES13693 CONFIG_FILES = $CONFIG_FILES
@@ -13753,7 +13753,7 @@
13753cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=113753cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
13754ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"13754ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
13755ac_cs_version="\\13755ac_cs_version="\\
13756indicator-appmenu config.status 0.3.113756indicator-appmenu config.status 0.3.2
13757configured by $0, generated by GNU Autoconf 2.68,13757configured by $0, generated by GNU Autoconf 2.68,
13758 with options \\"\$ac_cs_config\\"13758 with options \\"\$ac_cs_config\\"
1375913759
1376013760
=== modified file 'configure.ac'
--- configure.ac 2011-09-29 15:25:16 +0000
+++ configure.ac 2011-10-13 18:40:32 +0000
@@ -1,11 +1,11 @@
11
2AC_INIT(indicator-appmenu, 0.3.1, ted@canonical.com)2AC_INIT(indicator-appmenu, 0.3.2, ted@canonical.com)
3AC_COPYRIGHT([Copyright 2010 Canonical])3AC_COPYRIGHT([Copyright 2010 Canonical])
44
5AC_PREREQ(2.53)5AC_PREREQ(2.53)
66
7AM_CONFIG_HEADER(config.h)7AM_CONFIG_HEADER(config.h)
8AM_INIT_AUTOMAKE(indicator-appmenu, 0.3.1)8AM_INIT_AUTOMAKE(indicator-appmenu, 0.3.2)
99
10AM_MAINTAINER_MODE10AM_MAINTAINER_MODE
1111
1212
=== modified file 'debian/changelog'
--- debian/changelog 2011-10-06 14:31:34 +0000
+++ debian/changelog 2011-10-13 18:40:32 +0000
@@ -1,3 +1,11 @@
1indicator-appmenu (0.3.2-0ubuntu1~ppa1) oneiric; urgency=low
2
3 * New upstream release.
4 * Ensure that the label is ref'd using a ref_sink()
5 * Drop debian/patches/double-ref-of-entry-label.patch: Upstream
6
7 -- Ted Gould <ted@ubuntu.com> Thu, 13 Oct 2011 13:38:29 -0500
8
1indicator-appmenu (0.3.1-0ubuntu2) oneiric; urgency=low9indicator-appmenu (0.3.1-0ubuntu2) oneiric; urgency=low
210
3 * debian/patches/double-ref-of-entry-label.patch:11 * debian/patches/double-ref-of-entry-label.patch:
412
=== removed directory 'debian/patches'
=== removed file 'debian/patches/double-ref-of-entry-label.patch'
--- debian/patches/double-ref-of-entry-label.patch 2011-10-06 14:31:34 +0000
+++ debian/patches/double-ref-of-entry-label.patch 1970-01-01 00:00:00 +0000
@@ -1,17 +0,0 @@
1Description: Don't add a second ref to a label, just sink the one we own
2Origin: https://code.launchpad.net/~mterry/indicator-appmenu/double-ref-of-entry-label/+merge/78300
3Author: Michael Terry <michael.terry@canonical.com>
4
5Index: indicator-appmenu/src/window-menus.c
6===================================================================
7--- indicator-appmenu.orig/src/window-menus.c 2011-10-06 10:17:10.670272189 -0400
8+++ indicator-appmenu/src/window-menus.c 2011-10-06 10:17:48.794272592 -0400
9@@ -742,7 +742,7 @@
10 entry->label = GTK_LABEL(gtk_label_new_with_mnemonic(dbusmenu_menuitem_property_get(newentry, DBUSMENU_MENUITEM_PROP_LABEL)));
11
12 if (entry->label != NULL) {
13- g_object_ref(entry->label);
14+ g_object_ref_sink(entry->label);
15 }
16
17 entry->accessible_desc = dbusmenu_menuitem_property_get(newentry, DBUSMENU_MENUITEM_PROP_LABEL);
180
=== removed file 'debian/patches/series'
--- debian/patches/series 2011-10-06 14:31:34 +0000
+++ debian/patches/series 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1double-ref-of-entry-label.patch
20
=== modified file 'src/window-menus.c'
--- src/window-menus.c 2011-09-29 15:25:16 +0000
+++ src/window-menus.c 2011-10-13 18:40:32 +0000
@@ -742,7 +742,7 @@
742 entry->label = GTK_LABEL(gtk_label_new_with_mnemonic(dbusmenu_menuitem_property_get(newentry, DBUSMENU_MENUITEM_PROP_LABEL)));742 entry->label = GTK_LABEL(gtk_label_new_with_mnemonic(dbusmenu_menuitem_property_get(newentry, DBUSMENU_MENUITEM_PROP_LABEL)));
743743
744 if (entry->label != NULL) {744 if (entry->label != NULL) {
745 g_object_ref(entry->label);745 g_object_ref_sink(entry->label);
746 }746 }
747747
748 entry->accessible_desc = dbusmenu_menuitem_property_get(newentry, DBUSMENU_MENUITEM_PROP_LABEL);748 entry->accessible_desc = dbusmenu_menuitem_property_get(newentry, DBUSMENU_MENUITEM_PROP_LABEL);

Subscribers

People subscribed via source and target branches

to all changes: