Merge lp:~ignacio-nin/percona-xtradb-cluster/pxc-bug1171759 into lp:percona-xtradb-cluster/percona-xtradb-cluster-5.5

Proposed by Ignacio Nin
Status: Rejected
Rejected by: Raghavendra D Prabhu
Proposed branch: lp:~ignacio-nin/percona-xtradb-cluster/pxc-bug1171759
Merge into: lp:percona-xtradb-cluster/percona-xtradb-cluster-5.5
Prerequisite: lp:~percona-core/percona-xtradb-cluster/release-5.5.30
Diff against target: 20 lines (+10/-0)
1 file modified
build/percona-xtradb-cluster.spec (+10/-0)
To merge this branch: bzr merge lp:~ignacio-nin/percona-xtradb-cluster/pxc-bug1171759
Reviewer Review Type Date Requested Status
Raghavendra D Prabhu (community) Needs Information
Review via email: mp+160513@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

Same comment as that of Laurynas for PS merge, though this can be done for next release.

However, the code looks fine. Has it been tested?

review: Needs Information
Revision history for this message
Ignacio Nin (ignacio-nin) wrote :

> Same comment as that of Laurynas for PS merge, though this can be done for
> next release.
>
> However, the code looks fine. Has it been tested?

It works, but if we're going to push different code to 5.5 let's discard this and wait for the new code.

Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

Ok. we can wait since this is not critical.

Unmerged revisions

406. By Ignacio Nin

Merge fix for bug #1171759

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'build/percona-xtradb-cluster.spec'
--- build/percona-xtradb-cluster.spec 2013-04-23 22:05:53 +0000
+++ build/percona-xtradb-cluster.spec 2013-04-23 22:06:04 +0000
@@ -585,6 +585,16 @@
585# FIXME: the shared libraries to use libmysql*-$major.$minor.so syntax585# FIXME: the shared libraries to use libmysql*-$major.$minor.so syntax
586mv -v $RBR/%{_libdir}/*.a $RBR/%{_libdir}/mysql/586mv -v $RBR/%{_libdir}/*.a $RBR/%{_libdir}/mysql/
587587
588# libmysqlclient_r.so.18 and libmysqlclient_r.so.18.0.0 (generated by
589# libmysql/CMakeLists.txt) point to libmysqlclient.so instead of the versioned
590# libmysqlclient.so.18. Since libmysqlclient.so will live in a separate
591# package, we want these to point to the versioned library.
592for l in "$RBR%{_libdir}/libmysqlclient_r.so.18"*
593do
594 rm "$l"
595 ln -s "$(echo "$(basename "$l")" | sed 's/_r//')" "$l"
596done
597
588# Install logrotate and autostart598# Install logrotate and autostart
589install -m 644 $MBD/release/support-files/mysql-log-rotate $RBR%{_sysconfdir}/logrotate.d/mysql599install -m 644 $MBD/release/support-files/mysql-log-rotate $RBR%{_sysconfdir}/logrotate.d/mysql
590install -m 755 $MBD/release/support-files/mysql.server $RBR%{_sysconfdir}/init.d/mysql600install -m 755 $MBD/release/support-files/mysql.server $RBR%{_sysconfdir}/init.d/mysql

Subscribers

People subscribed via source and target branches

to all changes: