Merge lp:~ian-clatworthy/bzr/faster-branch-in-shared-repo into lp:~bzr/bzr/trunk-old

Proposed by Ian Clatworthy
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ian-clatworthy/bzr/faster-branch-in-shared-repo
Merge into: lp:~bzr/bzr/trunk-old
Diff against target: 32 lines
To merge this branch: bzr merge lp:~ian-clatworthy/bzr/faster-branch-in-shared-repo
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Review via email: mp+6737@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

This small patch speeds up branch in a shared repo for development6-rich-root format. For OOo, the time drops from 265 seconds to 95 seconds.

Revision history for this message
Robert Collins (lifeless) wrote :

 review approve
it would be nice, if possible, to test this.

-Rob

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NEWS'
--- NEWS 2009-05-22 01:44:19 +0000
+++ NEWS 2009-05-22 05:35:15 +0000
@@ -18,6 +18,9 @@
18Improvements18Improvements
19************19************
2020
21* ``bzr branch`` in a shared repository is now faster for
22 development6-rich-root format. (Ian Clatworthy)
23
21* ``bzr branch --notree`` is now faster. (Ian Clatworthy)24* ``bzr branch --notree`` is now faster. (Ian Clatworthy)
2225
23Bug Fixes26Bug Fixes
2427
=== modified file 'bzrlib/workingtree_4.py'
--- bzrlib/workingtree_4.py 2009-05-05 05:39:41 +0000
+++ bzrlib/workingtree_4.py 2009-05-22 05:35:15 +0000
@@ -1434,6 +1434,14 @@
1434 if basis_root_id is not None:1434 if basis_root_id is not None:
1435 wt._set_root_id(basis_root_id)1435 wt._set_root_id(basis_root_id)
1436 wt.flush()1436 wt.flush()
1437 # If content filtering is supported, do not use the accelerator
1438 # tree - the cost of transforming the content both ways and
1439 # checking for changed content can outweight the gains it gives.
1440 # Note: do NOT move this logic up higher - using the basis from
1441 # the accelerator tree is still desirable because that can save
1442 # a minute or more of processing on large trees!
1443 if wt.supports_content_filtering():
1444 accelerator_tree = None
1437 # delta_from_tree is safe even for DirStateRevisionTrees,1445 # delta_from_tree is safe even for DirStateRevisionTrees,
1438 # because wt4.apply_inventory_delta does not mutate the input1446 # because wt4.apply_inventory_delta does not mutate the input
1439 # inventory entries.1447 # inventory entries.