Merge lp:~hyuchia/noise/releases-info into lp:~elementary-apps/noise/trunk

Proposed by Diego Islas Ocampo
Status: Merged
Approved by: Danielle Foré
Approved revision: 2052
Merged at revision: 2058
Proposed branch: lp:~hyuchia/noise/releases-info
Merge into: lp:~elementary-apps/noise/trunk
Diff against target: 97 lines (+55/-35)
1 file modified
data/org.pantheon.noise.appdata.xml.in (+55/-35)
To merge this branch: bzr merge lp:~hyuchia/noise/releases-info
Reviewer Review Type Date Requested Status
Jeremy Wootten code Approve
Review via email: mp+318864@code.launchpad.net

Commit message

Add the release information to the AppData.xml to provide appcenter support

Description of the change

Add the release information to the AppData.xml to provide appcenter support

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

In order to ease the burden on translators, please use the following common descriptions:

* Security fixes
* Various crash fixes
* New translations
* Minor bug fixes

Please do not use the following:
* Minor bug fixes and translations updates.
* Apply minor bug fixes
* Translations Updates

Also I am not sure about the <p> paragraphs, why are they not all <li> list items?

Revision history for this message
Diego Islas Ocampo (hyuchia) wrote :

The paragraphs are mainly to keep appstream-util happy, but I think they should be added so there is a small description of every release instead of just a list of changes, the description can be used for a preview of the update and the description + list for an expanded view.

I'll change the descriptions for the common ones but should I also limit the file to 4 releases (or maybe just the ones for the current elementary release cycle)? That may also help ease the burden.

Revision history for this message
Cody Garver (codygarver) wrote :

Yeah I think you're right, start at 0.4

lp:~hyuchia/noise/releases-info updated
2052. By Diego Islas Ocampo

Update descriptions and reduce releases to current cycle

Revision history for this message
Diego Islas Ocampo (hyuchia) wrote :

All right, I've removed the releases from other cycles and used the common descriptions.

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Passes appstreamcli validate --pedantic.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/org.pantheon.noise.appdata.xml.in'
--- data/org.pantheon.noise.appdata.xml.in 2016-12-01 11:45:45 +0000
+++ data/org.pantheon.noise.appdata.xml.in 2017-03-09 17:57:23 +0000
@@ -1,38 +1,58 @@
1<?xml version="1.0" encoding="UTF-8"?>1<?xml version="1.0" encoding="UTF-8"?>
2<!-- Copyright 2015 elementary, LLC <contact@elementary.io> -->2<!-- Copyright 2015 elementary, LLC <contact@elementary.io> -->
3<component type="desktop">3<component type="desktop-application">
4 <id>org.pantheon.noise.desktop</id>4 <id>org.pantheon.noise.desktop</id>
5 <metadata_license>CC0-1.0</metadata_license>5 <metadata_license>CC0-1.0</metadata_license>
6 <project_group>elementary</project_group>6 <project_group>elementary</project_group>
7 <project_license>GPL-3.0+</project_license>7 <project_license>GPL-3.0+</project_license>
8 <_name>Music</_name>8 <_name>Music</_name>
9 <_summary>The official elementary music player</_summary>9 <_summary>The official elementary music player</_summary>
10 <description>10 <description>
11 <_p>11 <_p>
12 Music is a fast and beautiful audio player with a focus on12 Music is a fast and beautiful audio player with a focus on
13 music and libraries. It handles external devices, CDs, and13 music and libraries. It handles external devices, CDs, and
14 album art.14 album art.
15 </_p>15 </_p>
16 </description>16 </description>
17 <releases>17 <releases>
18 <release timestamp="1480592595" version="0.4.0.2"/>18 <release version="0.4.0.2" date="2016-12-01" urgency="medium">
19 <release timestamp="1427915704" version="0.3.1"/>19 ⁠<description>
20 <release timestamp="1401003480" version="0.3.0"/>20 <_p>Minor bug fixes.</_p>
21 <release timestamp="1376719060" version="0.2.4"/>21 ⁠</description>
22 <release timestamp="1374379743" version="0.2.3"/>22 </release>
23 <release timestamp="1372369509" version="0.2.2"/>23 <release version="0.4.0.1" date="2016-09-20" urgency="medium">
24 <release timestamp="1370825702" version="0.2.1"/>24 ⁠<description>
25 <release timestamp="1355236601" version="0.2.0"/>25 <_p>Add rounded bottom window corner.</_p>
26 <release timestamp="1320168563" version="0.1.0"/>26 <ul>
27 </releases>27 <_li>Minor bug fixes</_li>
28 <provides>28 <_li>New translations</_li>
29 <binary>noise</binary>29 </ul>
30 <library>libnoise-core.so.0</library>30 ⁠</description>
31 </provides>31 </release>
32 <developer_name>elementary LLC.</developer_name>32 <release version="0.4.0" date="2016-08-10" urgency="medium">
33 <url type="homepage">http://elementary.io/</url>33 ⁠<description>
34 <url type="bugtracker">https://bugs.launchpad.net/noise</url>34 <_p>Release for Loki.</_p>
35 <url type="donation">https://elementary.io/get-involved#funding</url>35 <ul>
36 <url type="help">https://elementaryos.stackexchange.com/questions/tagged/noise</url>36 <_li>Add support for Opus Ogg</_li>
37 <update_contact>contact_at_elementary.io</update_contact>37 <_li>Fix Ctrl+Q support for non-Latin keyboard layouts</_li>
38 <_li>Reorganize media edition layout</_li>
39 <_li>Port grid to support HiDPI displays</_li>
40 <_li>Update icons to latest elementary icon release</_li>
41 <_li>Respect privacy mode</_li>
42 <_li>Minor bug fixes</_li>
43 <_li>New translations</_li>
44 </ul>
45 ⁠</description>
46 </release>
47 </releases>
48 <provides>
49 <binary>noise</binary>
50 <library>libnoise-core.so.0</library>
51 </provides>
52 <developer_name>elementary LLC.</developer_name>
53 <url type="homepage">http://elementary.io/</url>
54 <url type="bugtracker">https://bugs.launchpad.net/noise</url>
55 <url type="donation">https://elementary.io/get-involved#funding</url>
56 <url type="help">https://elementaryos.stackexchange.com/questions/tagged/noise</url>
57 <update_contact>contact_at_elementary.io</update_contact>
38</component>58</component>

Subscribers

People subscribed via source and target branches