Merge lp:~hloeung/ubuntu-repository-cache/add-accept-encoding-headers into lp:ubuntu-repository-cache
Proposed by
Haw Loeung
Status: | Merged |
---|---|
Approved by: | Haw Loeung |
Approved revision: | 331 |
Merged at revision: | 330 |
Proposed branch: | lp:~hloeung/ubuntu-repository-cache/add-accept-encoding-headers |
Merge into: | lp:ubuntu-repository-cache |
Diff against target: |
60 lines (+19/-6) 3 files modified
files/health_check.py (+1/-0) lib/ubuntu_repository_cache/apache.py (+12/-5) lib/ubuntu_repository_cache/squid.py (+6/-1) |
To merge this branch: | bzr merge lp:~hloeung/ubuntu-repository-cache/add-accept-encoding-headers |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thomas Cuthbert (community) | Approve | ||
Canonical IS Reviewers | Pending | ||
Review via email: mp+399399@code.launchpad.net |
Commit message
Add 'Accept-Encoding' in nrpe and health checks
Upstream archives use mod_deflate which sets 'Vary: Accept-Encoding' on responses, so check_http should set that header.
This also reduces the logging spam from squid:
| 2021/03/10 00:15:00 kid1| varyEvaluateMatch: Oops. Not a Vary match on second attempt, 'http://
| 2021/03/10 00:15:00 kid1| clientProcessHit: Vary object loop!
We also hope to reduce squid memory usage (mem_node) as discovered by
tcuthbert.
To post a comment you must log in.
LGTM +1