Merge lp:~hloeung/langpack-o-matic/ssmtp-misconfigured into lp:langpack-o-matic

[Haw Loeung]

Reconfigure ssmtp configuration

It's wrong, it misconfigures ssmtp causing undeliverable mail and
adding to mail logs noise.

This fixes that to send all root emails to <email address hidden> rather than root@localhost. We also sent a proper domain and enforce that so we know these emails are from or related to Ubuntu's langpack-o-matic.

Luckily, I have access to inspect the unit and there's no mail successfully delivered:

ubuntu@juju-prod-ues-langpack-machine-1:~$ zgrep -v 'Recipient address rejected: User unknown in local recipient table' /var/log/mail.log /var/log/mail.log.1 /var/log/mail.log.2.gz
/var/log/mail.log:Sep 2 01:15:03 juju-prod-ues-langpack-machine-1 sSMTP[32719]: Sent mail for root@localhost (221 2.0.0 Bye) uid=0 username=root outbytes=667
/var/log/mail.log.1:Aug 25 08:17:08 juju-prod-ues-langpack-machine-1 sSMTP[20904]: Unable to connect to "mx.canonical.com" port 25.
/var/log/mail.log.1:Aug 25 08:17:08 juju-prod-ues-langpack-machine-1 sSMTP[20904]: Cannot open mx.canonical.com:25
ubuntu@juju-prod-ues-langpack-machine-1:~$

[Sebastien Bacher (seb128)]

Thanks for the report

charms/xenial/langpack-o-matic/hooks/start

sets <email address hidden> in the crontab, shouldn't it lead to a valid email being used?

review: Needs Information

[Haw Loeung (hloeung)]

On Wed, Oct 20, 2021 at 03:37:43PM -0000, Sebastien Bacher wrote:
> charms/xenial/langpack-o-matic/hooks/start
>
> sets <email address hidden> in the crontab, shouldn't it lead to a valid email being used?

Nope, that's setting the recipient address. You can check your
mailbox, you're not receving these emails. They're bouncing and coming
to us.

An example of one that came just recently:

| https://pastebin.canonical.com/p/8hJ3FtdT6h/

[Haw Loeung (hloeung)]

I'll mark this as WIP, will have a play around with getting a working ssmtp config going.

[Sebastien Bacher (seb128)]

thanks!

[Haw Loeung (hloeung)]

Re-review please?

[Haw Loeung (hloeung)]

Git - https://code.launchpad.net/~hloeung/langpack-o-matic/+git/langpack-o-matic/+merge/432350

review: Disapprove

Unmerged revisions

597. By Haw Loeung on 2022-10-29

Don't allow overriding from domain

596. By Haw Loeung on 2022-10-29

Reconfigure ssmtp

All root destined emails to be sent to <email address hidden>. We
also try use langpack-o-matic.ubuntu.com as the sender's domain where
we can.

595. By Haw Loeung on 2021-09-02

Remove ssmtp configuration

It's wrong, it misconfigures ssmtp causing undeliverable mail and
adding to mail logs noise:

| Sep 2 01:15:02 seviper postfix/smtpd[6486]: NOQUEUE: reject_warning: RCPT from ...: 504 5.5.2 <localhost>: Helo command rejected: need fully-qualified hostname; from=<root@localhost> to=<ubuntu@localhost> proto=SMTP helo=<localhost>
| Sep 2 01:15:02 seviper postfix/smtpd[6486]: NOQUEUE: reject_warning: RCPT from ...: 504 5.5.2 <ubuntu@localhost>: Recipient address rejected: need fully-qualified address; from=<root@localhost> to=<ubuntu@localhost> proto=SMTP helo=<localhost>
| Sep 2 01:15:02 seviper postfix/smtpd[6486]: NOQUEUE: reject_warning: RCPT from ...: 504 5.5.2 <root@localhost>: Sender address rejected: need fully-qualified address; from=<root@localhost> to=<ubuntu@localhost> proto=SMTP helo=<localhost>

=== added directory 'charms'
=== added directory 'charms/xenial'
=== added directory 'charms/xenial/langpack-o-matic'
=== added directory 'charms/xenial/langpack-o-matic/hooks'
=== added file 'charms/xenial/langpack-o-matic/hooks/install.OTHER'
--- charms/xenial/langpack-o-matic/hooks/install.OTHER	1970-01-01 00:00:00 +0000
+++ charms/xenial/langpack-o-matic/hooks/install.OTHER	2022-10-29 21:28:16 +0000
@@ -0,0 +1,35 @@
+#!/bin/sh
+set -e
+
+juju-log "Make host name resolvable (https://launchpad.net/bugs/1475260)"
+H=$(hostname)
+getent hosts $H  || echo "127.0.1.1 $H" >> /etc/hosts
+
+juju-log 'Invoking charm-pre-install hooks'
+[ -d exec.d ] && ( for f in exec.d/*/charm-pre-install; do [ -x $f ] && /bin/sh -c "$f"; done )
+
+juju-log "Installing dependencies"
+apt-get install -y build-essential libgettextpo-dev debhelper fakeroot bzr ssmtp python-launchpadlib python-apt dput
+apt-get install -y --no-install-recommends devscripts lintian
+
+juju-log "Checking out code"
+cat <<EOF | su - ubuntu
+set -e
+if [ ! -d langpack-o-matic ]; then
+    bzr branch lp:langpack-o-matic
+else
+    (cd langpack-o-matic; bzr pull)
+fi
+make -C langpack-o-matic/bin
+EOF
+
+# [e-mail] from charms/xenial/langpack-o-matic/hooks/start
+juju-log "Configuring ssmtp"
+mx="$(host -t MX ubuntu.com | sed 's/^.* //; s/\.$//')"
+cat <<EOF > /etc/ssmtp/ssmtp.conf
+root=[e-mail]
+mailhub=$mx
+hostname=langpack-o-matic.ubuntu.com
+rewriteDomain=langpack-o-matic.ubuntu.com
+FromLineOverride=no
+EOF