Merge ~hloeung/jenkins-agent-charm:switch-to-layer-status into jenkins-agent-charm:master
Proposed by
Haw Loeung
Status: | Merged |
---|---|
Approved by: | Alexandre Gomes |
Approved revision: | 901a909d302fb4e3eeaa00be8cb2401a25240495 |
Merged at revision: | e010d61685b05c5a20614b23fd97a94fb9bac2e2 |
Proposed branch: | ~hloeung/jenkins-agent-charm:switch-to-layer-status |
Merge into: | jenkins-agent-charm:master |
Diff against target: |
175 lines (+26/-22) 3 files modified
layer.yaml (+1/-0) reactive/jenkins_slave.py (+24/-22) tests/unit/test_jenkins_slave.py (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joel Sing (community) | +1 | Approve | |
Canonical IS Reviewers | Pending | ||
Review via email: mp+364411@code.launchpad.net |
Commit message
Switch from hookenv.
Description of the change
As advised by Stuart, using layer-status has many benefits. One major one being that we don't have to keep track of 'blocked' status and that it is set to be the final state (avoids bouncing between non-blocked and blocked).
To post a comment you must log in.
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.