Merge lp:~hikiko/unity/unity.1349281 into lp:unity

[Eleni Maria Stea]

LayoutSystem: make sure the exposed open windows are displayed in the "correct" order

In expose mode the windows were placed in z-order starting by the top-most window that was always put in the bottom right corner. After the change the windows are placed in a similar order to their initial one.

here's a video of the expose mode after the change: http://youtu.be/eYFTeJjaDQE

it fixes bug #1349281: the exposed open windows are not displayed in the "correct" order.

In expose mode the windows were placed in z-order starting by the top-most window that was always put in the bottom right corner. After the change the windows are placed in a similar order to their initial one.

here's a video of the expose mode after the change: http://youtu.be/eYFTeJjaDQE

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3877
http://jenkins.qa.ubuntu.com/job/unity-ci/1091/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-amd64-ci/178
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-armhf-ci/178
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-i386-ci/178

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1091/rebuild

review: Approve (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

See inline comments

[Marco Trevisan (Treviño) (3v1n0)]

Ah, one more thing...

In case where acentery == bcentery (for example when the windows are maximized), the windows should probably be ordered using the last time they have been used as a reference (return something like wm.GetWindowActiveNumber(a->xid) > wm.GetWindowActiveNumber(b->xid);)

[Eleni Maria Stea (hikiko)]

thanks :) I replied/fixed the issues

[Eleni Maria Stea (hikiko)]

> Ah, one more thing...
>
> In case where acentery == bcentery (for example when the windows are
> maximized), the windows should probably be ordered using the last time they
> have been used as a reference (return something like
> wm.GetWindowActiveNumber(a->xid) > wm.GetWindowActiveNumber(b->xid);)

no need to do that, I use stable_sort for that reason so what will happen is that since the windows are already ordered by z, if their center y are equal the first by z (topmost) will be first :D so, we shouldn't worry to order them manually :) I've tested this case!

[Eleni Maria Stea (hikiko)]

:s/top-most/the window that is first in the previous z-ordering

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3878
http://jenkins.qa.ubuntu.com/job/unity-ci/1092/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-amd64-ci/179
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-armhf-ci/179
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-i386-ci/179

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1092/rebuild

review: Approve (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

Nice!

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3879
http://jenkins.qa.ubuntu.com/job/unity-ci/1093/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-amd64-ci/180
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-armhf-ci/180
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-utopic-i386-ci/180

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1093/rebuild

review: Approve (continuous-integration)

=== modified file 'plugins/unityshell/src/unityshell.cpp'
--- plugins/unityshell/src/unityshell.cpp	2014-09-04 22:12:01 +0000
+++ plugins/unityshell/src/unityshell.cpp	2014-10-09 13:24:20 +0000
@@ -3718,7 +3718,6 @@
     }
 
     auto max_bounds = NuxGeometryFromCompRect(output.workArea());
-
     if (launcher_controller_->options()->hide_mode != LAUNCHER_HIDE_NEVER)
     {
       int monitor_width = unity_settings_.LauncherWidth(monitor);
@@ -3732,19 +3731,18 @@
     layout.spacing = local::SCALE_SPACING.CP(monitor_scale);
     int padding = local::SCALE_PADDING.CP(monitor_scale);
     max_bounds.Expand(-padding, -padding);
-    layout.LayoutWindows(layout_windows, max_bounds, final_bounds);
+    layout.LayoutWindowsNearest(layout_windows, max_bounds, final_bounds);
 
-    auto lw_it = layout_windows.begin();
-    for (auto const& sw : scaled_windows)
+    for (auto const& lw : layout_windows)
     {
-      if (lw_it == layout_windows.end())
-        break;
-
-      LayoutWindow::Ptr const& lw = *lw_it;
-
-      if (sw->window->id() != lw->xid)
+      auto sw_it = std::find_if(scaled_windows.begin(), scaled_windows.end(), [&lw] (ScaleWindow* sw) {
+        return sw->window->id() == lw->xid;
+      });
+
+      if (sw_it == scaled_windows.end())
         continue;
 
+      ScaleWindow* sw = *sw_it;
       ScaleSlot slot(CompRectFromNuxGeo(lw->result));
       slot.scale = lw->scale;
 
@@ -3761,7 +3759,6 @@
       slot.filled = true;
 
       sw->setSlot(slot);
-      ++lw_it;
     }
   }
 
 
=== modified file 'unity-shared/LayoutSystem.cpp'
--- unity-shared/LayoutSystem.cpp	2014-03-10 13:17:01 +0000
+++ unity-shared/LayoutSystem.cpp	2014-10-09 13:24:20 +0000
@@ -32,7 +32,33 @@
   if (windows.empty())
     return;
 
-  LayoutGridWindows(windows, max_bounds, final_bounds);
+  LayoutGridWindows(windows, GetRows(windows, max_bounds), max_bounds, final_bounds);
+}
+
+void LayoutSystem::LayoutWindowsNearest(LayoutWindow::Vector& windows, nux::Geometry const& max_bounds, nux::Geometry& final_bounds)
+{
+  if (windows.empty())
+    return;
+
+  std::stable_sort(windows.begin(), windows.end(), [](LayoutWindow::Ptr const& a, LayoutWindow::Ptr const& b) {
+    return a->geo.y < b->geo.y;
+  });
+
+  std::vector<LayoutWindow::Vector> rows = GetRows(windows, max_bounds);
+  LayoutWindow::Vector ordered_windows;
+
+  for (auto& row : rows)
+  {
+    std::stable_sort(row.begin(), row.end(), [](LayoutWindow::Ptr const& a, LayoutWindow::Ptr const& b) {
+      return (a->geo.x + a->geo.width / 2) < (b->geo.x + b->geo.width / 2);
+    });
+
+    for (auto const& win : row)
+      ordered_windows.push_back(win);
+  }
+
+  LayoutGridWindows(ordered_windows, rows, max_bounds, final_bounds);
+  windows = ordered_windows;
 }
 
 nux::Size LayoutSystem::GridSizeForWindows(LayoutWindow::Vector const& windows, nux::Geometry const& max_bounds) const
@@ -229,10 +255,8 @@
   return rows;
 }
 
-void LayoutSystem::LayoutGridWindows(LayoutWindow::Vector const& windows, nux::Geometry const& max_bounds, nux::Geometry& final_bounds)
+void LayoutSystem::LayoutGridWindows(LayoutWindow::Vector const& windows, std::vector<LayoutWindow::Vector> const& rows, nux::Geometry const& max_bounds, nux::Geometry& final_bounds)
 {
-  std::vector<LayoutWindow::Vector> const& rows = GetRows(windows, max_bounds);
-
   int height = rows.size();
   int non_spacing_height = max_bounds.height - ((height - 1) * spacing);
   int row_height = std::min (max_row_height(), non_spacing_height / height);
 
=== modified file 'unity-shared/LayoutSystem.h'
--- unity-shared/LayoutSystem.h	2014-03-10 13:17:01 +0000
+++ unity-shared/LayoutSystem.h	2014-10-09 13:24:20 +0000
@@ -64,10 +64,11 @@
   LayoutSystem();
 
   void LayoutWindows(LayoutWindow::Vector const& windows, nux::Geometry const& max_bounds, nux::Geometry& final_bounds);
+  void LayoutWindowsNearest(LayoutWindow::Vector& windows, nux::Geometry const& max_bounds, nux::Geometry& final_bounds);
   std::vector<int> GetRowSizes(LayoutWindow::Vector const& windows, nux::Geometry const& max_bounds) const;
 
 protected:
-  void LayoutGridWindows(LayoutWindow::Vector const& windows, nux::Geometry const& max_bounds, nux::Geometry& final_bounds);
+  void LayoutGridWindows(LayoutWindow::Vector const& windows, std::vector<LayoutWindow::Vector> const& rows, nux::Geometry const& max_bounds, nux::Geometry& final_bounds);
 
   nux::Geometry LayoutRow(LayoutWindow::Vector const& row, nux::Geometry const& row_bounds);
   nux::Geometry CompressAndPadRow(LayoutWindow::Vector const& windows, nux::Geometry const& max_bounds);