Merge lp:~gz/wikkid/support_python_2.4 into lp:wikkid
Proposed by
Martin Packman
Status: | Needs review |
---|---|
Proposed branch: | lp:~gz/wikkid/support_python_2.4 |
Merge into: | lp:wikkid |
Diff against target: |
147 lines (+17/-18) 8 files modified
wikkid/dispatcher.py (+2/-4) wikkid/tests/fakes.py (+1/-1) wikkid/tests/filestore.py (+1/-4) wikkid/tests/views/test_root.py (+4/-3) wikkid/user/baseuser.py (+5/-2) wikkid/user/bzr.py (+2/-2) wikkid/view/root.py (+1/-1) wikkid/view/urls.py (+1/-1) |
To merge this branch: | bzr merge lp:~gz/wikkid/support_python_2.4 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey | Needs Information | ||
Review via email: mp+40584@code.launchpad.net |
Description of the change
Simple set of changes that gets the test suite passing on my box. Mostly just adapting to some Python 2.4 limitations, but also an import bug and a few platform issues.
To post a comment you must log in.
Unmerged revisions
- 58. By Martin Packman
-
Fix import for email.Utils.
parseaddr - 57. By Martin Packman
-
Use WebOb support for HTTP exceptions as old style classes
- 56. By Martin Packman
-
Don't test for the mime type of *.cpp files as it may vary across platforms
- 55. By Martin Packman
-
Use old style percent style interpolation rather than str.format
- 54. By Martin Packman
-
Support old location of md5 as well as new hashlib module
- 53. By Martin Packman
-
Use os.path not bzrlib.urlutils functions for platform paths to fix load_view_modules
Hi Martin,
I've been thinking about this quite a bit. Personally what I'd like to do here is to have wikkid trunk requiring python 2.6 as I'd like to be able to use context managers and other 2.6 features.
However, if you'd like, I could create another series of wikkid that has the 2.4 support. I'd be happy if you want to be the maintainer of that branch.
Is there a reason that you want python 2.4 support?
Tim