Merge lp:~gz/brz/cert_reqs_none into lp:brz

[Martin Packman]

Only check https hostname if none cert_reqs=none

Only check https hostname if cert_reqs=required

Avoids error raised from standard lib ssl module:
ValueError: Cannot set verify_mode to CERT_NONE when check_hostname is enabled.

Also set check_hostname on the context rather than the module.

[Jelmer Vernooij (jelmer)]

One comment, as discussed in person

review: Approve

[Martin Packman (gz)]

Flipped the check though much of a muchness for now.

=== modified file 'breezy/transport/http/__init__.py'
--- breezy/transport/http/__init__.py	2019-06-15 11:55:54 +0000
+++ breezy/transport/http/__init__.py	2019-06-15 18:02:27 +0000
@@ -486,7 +486,7 @@
         try:
             ssl_context = ssl.create_default_context(
                 purpose=ssl.Purpose.SERVER_AUTH, cafile=ca_certs)
-            ssl.check_hostname = True
+            ssl_context.check_hostname = cert_reqs != ssl.CERT_NONE
             if self.cert_file:
                 ssl_context.load_cert_chain(
                     keyfile=self.key_file, certfile=self.cert_file)