Merge lp:~godricglow/postorius/bug_login_render_fix into lp:postorius

Proposed by Pranjal Yadav
Status: Merged
Merged at revision: 196
Proposed branch: lp:~godricglow/postorius/bug_login_render_fix
Merge into: lp:postorius
Diff against target: 38 lines (+3/-7)
2 files modified
src/postorius/templates/postorius/login.html (+1/-3)
src/postorius/views/list.py (+2/-4)
To merge this branch: bzr merge lp:~godricglow/postorius/bug_login_render_fix
Reviewer Review Type Date Requested Status
Florian Fuchs Approve
Review via email: mp+248049@code.launchpad.net

Description of the change

Fixed a rendering bug on login page, corrected missplaced new line character

To post a comment you must log in.
195. By Pranjal Yadav <email address hidden>

fixed 1308219 and merged trunk

196. By Pranjal Yadav <email address hidden>

fixed a rendering bug on login page

Revision history for this message
Florian Fuchs (flo-fuchs) wrote :

Hi Pranjal,

thanks for that. Looks better now... ;-)

Florian

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/postorius/templates/postorius/login.html'
--- src/postorius/templates/postorius/login.html 2015-01-17 17:23:59 +0000
+++ src/postorius/templates/postorius/login.html 2015-01-29 20:32:49 +0000
@@ -23,9 +23,7 @@
23 <input type="hidden" name="assertion" value="" />23 <input type="hidden" name="assertion" value="" />
24 <a rel="nofollow" id="browserid" href="#"><img src="{% static 'postorius/img/sign_in_blue.png' %}" alt="{% trans 'Login using BrowserID' %}" /></a>24 <a rel="nofollow" id="browserid" href="#"><img src="{% static 'postorius/img/sign_in_blue.png' %}" alt="{% trans 'Login using BrowserID' %}" /></a>
25 </form>25 </form>
26 <p>{% trans "Mozilla Persona is an easy way to sign into multiple websites, while26 <p>{% trans "Mozilla Persona is an easy way to sign into multiple websites, while still controlling your personal data. For more information <a href='http://www.mozilla.org/en-US/persona'>see the Mozilla website</a>" %}.</p>
27still controlling your personal data. For more information <a
28href='http://www.mozilla.org/en-US/persona'>see the Mozilla website</a>" %}.</p>
29 <noscript><p class="text-error">{% trans "Mozilla Persona requires the use of27 <noscript><p class="text-error">{% trans "Mozilla Persona requires the use of
30JavaScript." %}</p></noscript>28JavaScript." %}</p></noscript>
31 </div>29 </div>
3230
=== modified file 'src/postorius/views/list.py'
--- src/postorius/views/list.py 2015-01-19 15:03:09 +0000
+++ src/postorius/views/list.py 2015-01-29 20:32:49 +0000
@@ -66,8 +66,6 @@
66 % request.POST['owner_email']))66 % request.POST['owner_email']))
67 except HTTPError as e:67 except HTTPError as e:
68 messages.error(request, _(e.msg))68 messages.error(request, _(e.msg))
69 else:
70 owner_form = NewOwnerForm()
71 if 'moderator_email' in request.POST:69 if 'moderator_email' in request.POST:
72 moderator_form = NewModeratorForm(request.POST)70 moderator_form = NewModeratorForm(request.POST)
73 if moderator_form.is_valid():71 if moderator_form.is_valid():
@@ -79,8 +77,8 @@
79 % request.POST['moderator_email']))77 % request.POST['moderator_email']))
80 except HTTPError as e:78 except HTTPError as e:
81 messages.error(request, _(e.msg))79 messages.error(request, _(e.msg))
82 else:80 owner_form = NewOwnerForm()
83 moderator_form = NewModeratorForm()81 moderator_form = NewModeratorForm()
84 return render_to_response('postorius/lists/members.html',82 return render_to_response('postorius/lists/members.html',
85 {'list': self.mailing_list,83 {'list': self.mailing_list,
86 'owner_form': owner_form,84 'owner_form': owner_form,

Subscribers

People subscribed via source and target branches