Merge lp:~gilir/ubiquity/lp-546445 into lp:ubiquity

Proposed by Julien Lavergne
Status: Merged
Merged at revision: 4439
Proposed branch: lp:~gilir/ubiquity/lp-546445
Merge into: lp:ubiquity
Diff against target: 66 lines (+17/-2)
3 files modified
bin/ubiquity-dm (+9/-1)
debian/changelog (+6/-1)
debian/ubiquity.ubiquity.upstart (+2/-0)
To merge this branch: bzr merge lp:~gilir/ubiquity/lp-546445
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+41509@code.launchpad.net

Description of the change

Add support for Lubuntu in ubiquity-dm mode.

To post a comment you must log in.
lp:~gilir/ubiquity/lp-546445 updated
4436. By Evan

Do not filter out partitions in migration-assistant anymore.
parted_server is no longer running by the time it starts, but that's
of no matter as it runs long after the partitioning has been
committed.

4437. By Evan

Automatic update of included source packages: apt-setup
1:0.49ubuntu1, base-installer 1.114ubuntu1, choose-mirror
2.36ubuntu1, clock-setup 0.105ubuntu1, debian-installer-utils
1.81ubuntu1, grub-installer 1.57ubuntu1, hw-detect 1.81ubuntu1,
migration-assistant 0.6.8, netcfg 1.57ubuntu2, partconf 1.35,
partman-base 146ubuntu2, partman-basicfilesystems 68ubuntu1,
partman-basicmethods 46, partman-btrfs 4, partman-efi 22ubuntu1,
partman-ext3 61ubuntu1, partman-jfs 32, partman-newworld 24,
partman-partitioning 78ubuntu1, partman-reiserfs 49, partman-target
70ubuntu1, partman-xfs 46, preseed 1.47, yaboot-installer
1.1.18ubuntu1.

4438. By Evan

releasing version 2.5.1

Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks! This looks fine and I'll merge it. My only comment is that debian/oem-config.oem-config.upstart should be kept in sync with debian/ubiquity.ubiquity.upstart; I'll sort this out myself after merging your branch.

review: Approve
lp:~gilir/ubiquity/lp-546445 updated
4439. By Colin Watson

merge lp:~gilir/ubiquity/lp-546445

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/ubiquity-dm'
--- bin/ubiquity-dm 2010-09-21 08:29:43 +0000
+++ bin/ubiquity-dm 2010-11-22 20:26:15 +0000
@@ -350,10 +350,12 @@
350 wm_cmd = ['xfwm4']350 wm_cmd = ['xfwm4']
351 elif osextras.find_on_path('matchbox-window-manager'):351 elif osextras.find_on_path('matchbox-window-manager'):
352 wm_cmd = ['matchbox-window-manager']352 wm_cmd = ['matchbox-window-manager']
353 elif osextras.find_on_path('openbox-lubuntu'):
354 wm_cmd = ['openbox-lubuntu']
353 else:355 else:
354 raise MissingProgramError, \356 raise MissingProgramError, \
355 ("No window manager found (tried metacity, xfwm4, "357 ("No window manager found (tried metacity, xfwm4, "
356 "matchbox-window-manager)")358 "matchbox-window-manager, openbox-lubuntu)")
357 wm = subprocess.Popen(wm_cmd,359 wm = subprocess.Popen(wm_cmd,
358 stdin=null, stdout=logfile, stderr=logfile,360 stdin=null, stdout=logfile, stderr=logfile,
359 **maybe_drop_privileges)361 **maybe_drop_privileges)
@@ -376,6 +378,12 @@
376 stdin=null, stdout=logfile, stderr=logfile,378 stdin=null, stdout=logfile, stderr=logfile,
377 **maybe_drop_privileges))379 **maybe_drop_privileges))
378380
381 if osextras.find_on_path('lxsession'):
382 extras.append(subprocess.Popen(
383 ['lxsession','-s','Lubuntu', '-e', 'LXDE', '-a'],
384 stdin=null, stdout=logfile, stderr=logfile,
385 **maybe_drop_privileges))
386
379 if os.path.exists('/usr/lib/ubiquity/panel') and "xfwm4" not in wm_cmd:387 if os.path.exists('/usr/lib/ubiquity/panel') and "xfwm4" not in wm_cmd:
380 extras.append(subprocess.Popen(388 extras.append(subprocess.Popen(
381 ['/usr/lib/ubiquity/panel'],389 ['/usr/lib/ubiquity/panel'],
382390
=== modified file 'debian/changelog'
--- debian/changelog 2010-11-17 11:07:48 +0000
+++ debian/changelog 2010-11-22 20:26:15 +0000
@@ -8,7 +8,12 @@
8 * Expose the navigation control in the GTK frontend API.8 * Expose the navigation control in the GTK frontend API.
9 Thanks Ying-Chun Liu!9 Thanks Ying-Chun Liu!
1010
11 -- Colin Watson <cjwatson@ubuntu.com> Mon, 15 Nov 2010 12:05:19 +000011 [ Julien Lavergne ]
12 * debian/ubiquity.ubiquity.upstart:
13 - Add lxdm support.
14 * Add support for openbox-lubuntu and lxsession for ubiquity-dm (LP: #546445)
15
16 -- Julien Lavergne <gilir@ubuntu.com> Mon, 22 Nov 2010 19:45:30 +0100
1217
13ubiquity (2.5.0) natty; urgency=low18ubiquity (2.5.0) natty; urgency=low
1419
1520
=== modified file 'debian/ubiquity.ubiquity.upstart'
--- debian/ubiquity.ubiquity.upstart 2010-09-20 09:13:41 +0000
+++ debian/ubiquity.ubiquity.upstart 2010-11-22 20:26:15 +0000
@@ -10,11 +10,13 @@
10start on (starting gdm10start on (starting gdm
11 or starting kdm11 or starting kdm
12 or starting xdm12 or starting xdm
13 or starting lxdm
13 or starting uxlaunch)14 or starting uxlaunch)
14stop on (runlevel [06]15stop on (runlevel [06]
15 or stopping gdm16 or stopping gdm
16 or stopping kdm17 or stopping kdm
17 or stopping xdm18 or stopping xdm
19 or stopping lxdm
18 or stopping uxlaunch)20 or stopping uxlaunch)
1921
20task22task

Subscribers

People subscribed via source and target branches

to status/vote changes: