Merge lp:~gezakovacs/ubuntu/lucid/unetbootin/fix-10.10-desktop-iso-loading into lp:ubuntu/lucid-updates/unetbootin

Proposed by Luke Faraone
Status: Needs review
Proposed branch: lp:~gezakovacs/ubuntu/lucid/unetbootin/fix-10.10-desktop-iso-loading
Merge into: lp:ubuntu/lucid-updates/unetbootin
Diff against target: 97 lines (+58/-3)
3 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
unetbootin.cpp (+50/-2)
To merge this branch: bzr merge lp:~gezakovacs/ubuntu/lucid/unetbootin/fix-10.10-desktop-iso-loading
Reviewer Review Type Date Requested Status
Luke Faraone Approve
Review via email: mp+37784@code.launchpad.net

Description of the change

Fixes generated menu entries when loading Ubuntu 10.10 desktop iso. Has been tested against ubuntu-10.10-rc-desktop-amd64.iso and ubuntu-10.04-desktop-i386.iso

To post a comment you must log in.
Revision history for this message
Luke Faraone (lfaraone) wrote :

FYI, instead of incrementing the "0ubuntu1" revision for SRUs, we increment the portion after that: "0ubuntu0.10.04.2".

I filled out the SRU information for this bug. In the future, the sponsoree is expected to have already done so.

review: Approve

Unmerged revisions

17. By Geza Kovacs

Fixes issues when loading Ubuntu 10.10 desktop iso. (LP: #615285)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-05-11 11:11:22 +0000
+++ debian/changelog 2010-10-06 20:08:57 +0000
@@ -1,3 +1,9 @@
1unetbootin (408-1ubuntu1.10.04.1) lucid-proposed; urgency=low
2
3 * Fixes issues when loading Ubuntu 10.10 desktop iso. (LP: #615285)
4
5 -- Geza Kovacs <gkovacs@mit.edu> Wed, 06 Oct 2010 15:33:58 -0400
6
1unetbootin (408-1ubuntu0.10.04.1) lucid-proposed; urgency=low7unetbootin (408-1ubuntu0.10.04.1) lucid-proposed; urgency=low
28
3 * Include Ubuntu 10.04 LTS in the dropdown list for Ubuntu. (LP: #578841)9 * Include Ubuntu 10.04 LTS in the dropdown list for Ubuntu. (LP: #578841)
410
=== modified file 'debian/control'
--- debian/control 2009-09-27 14:48:46 +0000
+++ debian/control 2010-10-06 20:08:57 +0000
@@ -1,7 +1,8 @@
1Source: unetbootin1Source: unetbootin
2Section: utils2Section: utils
3Priority: optional3Priority: optional
4Maintainer: Eugene V. Lyubimkin <jackyf@debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Eugene V. Lyubimkin <jackyf@debian.org>
5Build-Depends: syslinux, debhelper (>= 7), libqt4-dev (>= 4.2)6Build-Depends: syslinux, debhelper (>= 7), libqt4-dev (>= 4.2)
6Standards-Version: 3.8.37Standards-Version: 3.8.3
7Vcs-Git: git://git.debian.org/git/collab-maint/unetbootin.git8Vcs-Git: git://git.debian.org/git/collab-maint/unetbootin.git
89
=== modified file 'unetbootin.cpp'
--- unetbootin.cpp 2010-02-14 09:16:41 +0000
+++ unetbootin.cpp 2010-10-06 20:08:57 +0000
@@ -1636,7 +1636,31 @@
1636 {1636 {
1637 includesfile = includesfile.right(includesfile.size() - 1).trimmed();1637 includesfile = includesfile.right(includesfile.size() - 1).trimmed();
1638 }1638 }
1639 QStringList includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);1639 QStringList includesfileL;
1640 for (int i = 0; i < archivefileconts.size(); ++i)
1641 {
1642 QString curentry = archivefileconts.at(i);
1643 if (curentry.endsWith("/") || curentry.endsWith(QDir::toNativeSeparators("/")))
1644 {
1645 curentry = curentry.left(curentry.size() - 1).trimmed();
1646 }
1647 if (curentry.contains("/"))
1648 {
1649 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf("/"));
1650 }
1651 else if (curentry.contains(QDir::toNativeSeparators("/")))
1652 {
1653 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf(QDir::toNativeSeparators("/")));
1654 }
1655 if (includesfile.compare(curentry, Qt::CaseInsensitive) == 0)
1656 {
1657 includesfileL.append(archivefileconts.at(i));
1658 }
1659 }
1660 if (includesfileL.isEmpty())
1661 {
1662 includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
1663 }
1640 if (!includesfileL.isEmpty())1664 if (!includesfileL.isEmpty())
1641 {1665 {
1642 for (int i = 0; i < includesfileL.size(); ++i)1666 for (int i = 0; i < includesfileL.size(); ++i)
@@ -1660,7 +1684,31 @@
1660 {1684 {
1661 includesfile = includesfile.right(includesfile.size() - 1).trimmed();1685 includesfile = includesfile.right(includesfile.size() - 1).trimmed();
1662 }1686 }
1663 QStringList includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);1687 QStringList includesfileL;
1688 for (int i = 0; i < archivefileconts.size(); ++i)
1689 {
1690 QString curentry = archivefileconts.at(i);
1691 if (curentry.endsWith("/") || curentry.endsWith(QDir::toNativeSeparators("/")))
1692 {
1693 curentry = curentry.left(curentry.size() - 1).trimmed();
1694 }
1695 if (curentry.contains("/"))
1696 {
1697 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf("/"));
1698 }
1699 else if (curentry.contains(QDir::toNativeSeparators("/")))
1700 {
1701 curentry = curentry.right(curentry.size() - 1 - curentry.indexOf(QDir::toNativeSeparators("/")));
1702 }
1703 if (includesfile.compare(curentry, Qt::CaseInsensitive) == 0)
1704 {
1705 includesfileL.append(archivefileconts.at(i));
1706 }
1707 }
1708 if (includesfileL.isEmpty())
1709 {
1710 includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
1711 }
1664 if (!includesfileL.isEmpty())1712 if (!includesfileL.isEmpty())
1665 {1713 {
1666 for (int i = 0; i < includesfileL.size(); ++i)1714 for (int i = 0; i < includesfileL.size(); ++i)

Subscribers

People subscribed via source and target branches

to all changes: