Merge lp:~gcollura/ubuntu-weather-app/fix-1297463 into lp:ubuntu-weather-app/obsolete.trunk

[Giulio Collura]

Fix bug 1297463

Set the application to run with wide aspect on the desktop.

Fix bug 1297463 about app width on desktop.

[Martin Borho (martin-borho)]

Hi Guilio,

thanks for the MP!

As the weather app uses the phone view as standard layout, it's not fortunate to set another initial size. https://bugs.launchpad.net/ubuntu-weather-app/+bug/1297463/comments/3

And I would not recommend to change the default layout from phone to tablet, since phone is the main focus at the moment. And a new design in the works.

Cheers
Martin

review: Abstain

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Yeah, unfortunately this will cause issues when run on the device. If there was some way we could have two separate default sizes, that would be awesome. I don't know how you can do that though.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Looks good!

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~gcollura/ubuntu-weather-app/fix-1297463/+merge/235937/+edit-commit-message

review: Needs Fixing (continuous-integration)

[Martin Borho (martin-borho)]

Alan, the problem doesn't occur on the device anymore? And the gray font in the sidemenu?

[Nicholas Skaggs (nskaggs)]

Indeed, the width changes need to be conditional based upon screen size.

review: Needs Fixing

[Giulio Collura (gcollura)]

> Indeed, the width changes need to be conditional based upon screen size.
I'll work on that possibly during the weekend :)

Giulio

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:372
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/304/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid-weather-app/15
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid-weather-app/15/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-vivid-amd64-ci/12

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/304/rebuild

review: Approve (continuous-integration)

Unmerged revisions

372. By Giulio Collura on 2014-09-23

Fix bug #1297463

=== modified file 'ubuntu-weather-app.qml'
--- ubuntu-weather-app.qml	2014-09-20 10:55:31 +0000
+++ ubuntu-weather-app.qml	2014-09-25 11:03:25 +0000
@@ -32,8 +32,8 @@
 
     id: mainView
     
-    width: units.gu(50)
-    height: units.gu(67)
+    width: units.gu(100)
+    height: units.gu(80)
 
     useDeprecatedToolbar: false