Merge lp:~gcollura/ubuntu-calculator-app/swipe-copy-button-improvements into lp:ubuntu-calculator-app
Proposed by
Giulio Collura
Status: | Merged |
---|---|
Approved by: | Bartosz Kosiorek |
Approved revision: | 77 |
Merged at revision: | 75 |
Proposed branch: | lp:~gcollura/ubuntu-calculator-app/swipe-copy-button-improvements |
Merge into: | lp:ubuntu-calculator-app |
Diff against target: |
87 lines (+29/-8) 2 files modified
app/ubuntu-calculator-app.qml (+22/-7) app/ui/KeyboardButton.qml (+7/-1) |
To merge this branch: | bzr merge lp:~gcollura/ubuntu-calculator-app/swipe-copy-button-improvements |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bartosz Kosiorek | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Riccardo Padovani | Approve | ||
Review via email: mp+247357@code.launchpad.net |
Commit message
Add swipe to copy feature on single calculation. Add pressed button effect and fix button height on landscape mode.
Description of the change
Various improvements. I've decided to put all of them in the same MP to save time :)
What I've done:
* Added swipe to copy on single calculation as Riccardo requested
* Added a small effect when a button gets pressed
* (REMOVED) Fix button height in landscape mode (see http://
Tell me what you think and if you see anything wrong.
Thank you!
Giulio
To post a comment you must log in.
PASSED: Continuous integration, rev:75 91.189. 93.70:8080/ job/ubuntu- calculator- app-ci/ 287/ 91.189. 93.70:8080/ job/generic- mediumtests- vivid/808 91.189. 93.70:8080/ job/generic- mediumtests- vivid/808/ artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/ubuntu- calculator- app-vivid- amd64-ci/ 9
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- calculator- app-ci/ 287/rebuild
http://