Merge lp:~gaul/percona-server/pwrite_partial_write into lp:percona-server/5.6
Proposed by
Andrew Gaul
Status: | Rejected |
---|---|
Rejected by: | Laurynas Biveinis |
Proposed branch: | lp:~gaul/percona-server/pwrite_partial_write |
Merge into: | lp:percona-server/5.6 |
Diff against target: |
20 lines (+4/-3) 1 file modified
Percona-Server/storage/innobase/os/os0file.cc (+4/-3) |
To merge this branch: | bzr merge lp:~gaul/percona-server/pwrite_partial_write |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Laurynas Biveinis (community) | Needs Resubmitting | ||
Review via email: mp+199611@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 519. By Andrew Gaul <email address hidden>
-
Handle partial writes in os0file.
cc:os_file_ pwrite This could cause ibd files to contain bogus trailing zeros and non-page
size file sizes, which XtraBackup asserts on.
Andrew -
Thanks for the patch. It is correct in general, I'm testing it with two additional changes:
- replace non-portable void* pointer arithmetics with an expression through casting to char*;
- the same bug is present in os_file_pread().
The same bug is present in os_file_ pread() /os_file_ pwrite( ) for systems that do not support pwrite()/pread(), e.g. Windows. We don't support any such platform, thus I am ignoring it for the now.
I'll attach the updated patch merge proposal to the bug report.