Merge lp:~gary-lasker/software-center/tos-urls-lp961538 into lp:software-center

Proposed by Gary Lasker
Status: Merged
Merged at revision: 2908
Proposed branch: lp:~gary-lasker/software-center/tos-urls-lp961538
Merge into: lp:software-center
Diff against target: 38 lines (+7/-3)
2 files modified
softwarecenter/enums.py (+5/-2)
softwarecenter/ui/gtk3/dialogs/dialog_tos.py (+2/-1)
To merge this branch: bzr merge lp:~gary-lasker/software-center/tos-urls-lp961538
Reviewer Review Type Date Requested Status
software-store-developers Pending
Review via email: mp+98732@code.launchpad.net

Description of the change

This branch implements Anthony's notes for bug 961538. It fixes the URLs and sets a separate URL for use in a web browser (where header/footers are included) vs. the embedded dialog (where they are not).

Thanks!

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'softwarecenter/enums.py'
--- softwarecenter/enums.py 2012-03-16 09:02:42 +0000
+++ softwarecenter/enums.py 2012-03-21 20:58:18 +0000
@@ -52,8 +52,11 @@
52UBUNTU_SSO_SERVICE = os.environ.get(52UBUNTU_SSO_SERVICE = os.environ.get(
53 "USSOC_SERVICE_URL", "https://login.ubuntu.com/api/1.0")53 "USSOC_SERVICE_URL", "https://login.ubuntu.com/api/1.0")
5454
55# the terms-of-service link55# the terms-of-service links (the first is for display in a web browser
56SOFTWARE_CENTER_TOS_LINK = "http://apps.ubuntu.com/cat/tos"56# as it has the header and footer, the second is for display in a dialog
57# as it lacks them and so looks better)
58SOFTWARE_CENTER_TOS_LINK = "https://apps.ubuntu.com/cat/tos/"
59SOFTWARE_CENTER_TOS_LINK_NO_HEADER = "https://apps.ubuntu.com/cat/tos/plain/ "
5760
58# version of the database, every time something gets added (like61# version of the database, every time something gets added (like
59# terms for mime-type) increase this (but keep as a string!)62# terms for mime-type) increase this (but keep as a string!)
6063
=== modified file 'softwarecenter/ui/gtk3/dialogs/dialog_tos.py'
--- softwarecenter/ui/gtk3/dialogs/dialog_tos.py 2012-03-19 14:38:10 +0000
+++ softwarecenter/ui/gtk3/dialogs/dialog_tos.py 2012-03-21 20:58:18 +0000
@@ -26,6 +26,7 @@
2626
27from softwarecenter.ui.gtk3.views.webkit import ScrolledWebkitWindow27from softwarecenter.ui.gtk3.views.webkit import ScrolledWebkitWindow
28from softwarecenter.ui.gtk3.widgets.spinner import SpinnerNotebook28from softwarecenter.ui.gtk3.widgets.spinner import SpinnerNotebook
29from softwarecenter.enums import SOFTWARE_CENTER_TOS_LINK_NO_HEADER
2930
3031
31class DialogTos(Gtk.Dialog):32class DialogTos(Gtk.Dialog):
@@ -65,7 +66,7 @@
6566
66 def run(self):67 def run(self):
67 self.spinner.show_spinner()68 self.spinner.show_spinner()
68 self.webkit.load_uri("http://apps.ubuntu.com/cat/tos")69 self.webkit.load_uri(SOFTWARE_CENTER_TOS_LINK_NO_HEADER)
69 return Gtk.Dialog.run(self)70 return Gtk.Dialog.run(self)
7071
71 def _on_load_status_changed(self, view, pspec):72 def _on_load_status_changed(self, view, pspec):

Subscribers

People subscribed via source and target branches