Merge lp:~gary-lasker/software-center/recommendations-string-change-lp986437-for-5.2 into lp:software-center/5.2
Status: | Merged |
---|---|
Merged at revision: | 3051 |
Proposed branch: | lp:~gary-lasker/software-center/recommendations-string-change-lp986437-for-5.2 |
Merge into: | lp:software-center/5.2 |
Diff against target: |
24 lines (+1/-10) 1 file modified
softwarecenter/ui/gtk3/widgets/recommendations.py (+1/-10) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/recommendations-string-change-lp986437-for-5.2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Planella (community) | Approve | ||
Michael Vogt | Approve | ||
Review via email: mp+111238@code.launchpad.net |
Commit message
* lp:~gary-lasker/software-center/recommendations-string-change-lp986437-for-5.2:
- switch to the updated recommendations opt-in string now that the corresponding
language pack updates are released and available (LP: #986437)
Description of the change
This branch contains the switchover to the modified recommendations opt-in string as described in bug 986437. Note that the string freeze exception was granted for Precise and we were holding this change until the corresponding language pack release occurred. These packs were released a while ago and so should be in place now and everything now seems ready for this merge.
To test, first launch from the branch in English to verify the text change, then test in another language (e.g. French) to verify that the translation is available and is displayed. Steps are as shown:
1. In a terminal, launch Software Center from inside this branch as shown:
$ PYTHONPATH=. python ./software-center
2. If you are currently opt-in to recommendations choose to opt-out using the menu item "View"->"Turn off Recommendations".
3. In the "Recommended for You" panel at the bottom of the lobby view, verify that the opt-in text reads "To make recommendations, Ubuntu Software Center will occasionally sent to Canonical a list of software currently installed" (note that the word "anonymous" does not appear).
4. Close Software Center and reopen in a different language, e.g., French. First, of course, install the corresponding language pack if you have not done this already. Launch as shown in the branch directory:
$ LANGUAGE=fr_FR.utf8 PYTHONPATH=. python ./software-center
5. Verify that the opt-in text is correctly translated into French.
Note that I also tested this with traditional Chinese using "LANGUAGE=
Many thanks for your review!
P.S. As per all of our other 5.2 fixes, we'll need this one to get merged into trunk as well and released into Quantal before the SRU team will approve an upload of this into precise-proposed.
Thanks again!