Merge lp:~gary-lasker/software-center/lp630248-fix-for-3.0 into lp:software-center/3.0
Proposed by
Gary Lasker
Status: | Merged |
---|---|
Merged at revision: | 1121 |
Proposed branch: | lp:~gary-lasker/software-center/lp630248-fix-for-3.0 |
Merge into: | lp:software-center/3.0 |
Diff against target: |
46 lines (+10/-7) 2 files modified
debian/changelog (+8/-1) softwarecenter/app.py (+2/-6) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/lp630248-fix-for-3.0 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt | Pending | ||
Review via email: mp+49178@code.launchpad.net |
Description of the change
Hi Michael, I thought we might consider cherrypicking this fix for bug 630248 for Maverick, based on the number of dupes where folks report being unable to run Software Center after upgrading to Maverick.
I also noticed that the fix for bug 639701 in the 3.0 branch is still pending a release for Maverick. Think an SRU for these might be in order?
Thanks!
Gary
To post a comment you must log in.
On Thu, Feb 10, 2011 at 04:57:32AM -0000, Gary Lasker wrote: /bugs.launchpad .net/bugs/ 630248 /code.launchpad .net/~gary- lasker/ software- center/ lp630248- fix-for- 3.0/+merge/ 49178
> Gary Lasker has proposed merging lp:~gary-lasker/software-center/lp630248-fix-for-3.0 into lp:software-center/3.0.
>
> Requested reviews:
> Michael Vogt (mvo)
> Related bugs:
> #630248 software-center crashed with ValueError in _parse_localename()
> https:/
>
> For more details, see:
> https:/
>
> Hi Michael, I thought we might consider cherrypicking this fix for bug 630248 for Maverick, based on the number of dupes where folks report being unable to run Software Center after upgrading to Maverick.
Thanks a lot for this!
> I also noticed that the fix for bug 639701 in the 3.0 branch is still pending a release for Maverick. Think an SRU for these might be in order?
Indeed, I merged your branch and uploaded it to maverick-proposed now.
Cheers,
Michael
> Thanks! /code.launchpad .net/~gary- lasker/ software- center/ lp630248- fix-for- 3.0/+merge/ 49178
> Gary
>
> --
> https:/
> You are requested to review the proposed merge of lp:~gary-lasker/software-center/lp630248-fix-for-3.0 into lp:software-center/3.0.
> === modified file 'debian/changelog' utils.py, view/appdetails view_gtk. py: app.py: /app.py' app.py 2010-10-03 11:09:16 +0000 app.py 2011-02-10 04:56:49 +0000 setlocale( locale. LC_ALL, "") exception( "setlocale failed") exception( "setlocale failed, reseting to C") setlocale( locale. LC_ALL, "C") dbus_or_ bring_other_ instance_ to_front( args) database_ rebuilding_ listener( ) setlocale( locale. LC_ALL, "") exception( "setlocale failed")
> --- debian/changelog 2010-12-09 22:51:46 +0000
> +++ debian/changelog 2011-02-10 04:56:49 +0000
> @@ -1,10 +1,17 @@
> software-center (3.0.8) UNRELEASED; urgency=low
>
> + [ Gary Lasker ]
> * softwarecenter/
> softwarecenter/
> - disable find-it-in-the-menu under Unity (LP: #639701)
>
> - -- Gary Lasker <email address hidden> Thu, 09 Dec 2010 17:50:58 -0500
> + [ Michael Vogt ]
> + * softwarecenter/
> + - on a invalid locale, reset the locale to "C" to avoid
> + later crashes in the apthistory that uses strptime
> + (lp: #630248)
> +
> + -- Gary Lasker <email address hidden> Wed, 09 Feb 2011 23:28:37 -0500
>
> software-center (3.0.7) maverick-proposed; urgency=low
>
>
> === modified file 'softwarecenter
> --- softwarecenter/
> +++ softwarecenter/
> @@ -117,18 +117,14 @@
> try:
> locale.
> except:
> - self._logger.
> + self._logger.
> + locale.
>
> # setup dbus and exit if there is another instance already
> # running
> self.setup_
> self.setup_
>
> - try:
> - locale.
> - except Exception, e:
> - self._logger.
> -
> # distro specific stuff
> self.distro = get_distro()
>
>