Merge lp:~gary-lasker/software-center/installed-pane-refresh into lp:software-center

[Gary Lasker]

This branch implements a simple, low-risk fix to the quite annoying usability issue of the installed view pane refreshing every time that it is displayed, whether or not its contents have changed. Any expanded treeview categories are reset each time, and the user's place in the list is lost as well. Please take a look at corresponding bug 828887 for details, including steps to reproduce.

With this change, we only refresh the view when the contents have actually changed due to one of either 1. a different channel being selected, or 2. when the pane content itself has been refreshed (e.g., when an item is installed or removed).

All unit tests pass and I did a fair bit of additional testing of the application in use and was unable to find any regression or unwanted side effects.

Note that there is still room for improvement in the installed pane refreshing. Particularly, when there is a refresh on the view due to an install or removal, the entire treeview collapses again. This is annoying, but is far less often a use case than the one addressed by this fix (that is, simple navaigating between views).

Many thanks in advance for your review!

[Michael Vogt (mvo)]

Thanks, that looks good.

review: Approve

=== modified file 'softwarecenter/ui/gtk3/panes/installedpane.py'
--- softwarecenter/ui/gtk3/panes/installedpane.py	2012-03-15 01:00:27 +0000
+++ softwarecenter/ui/gtk3/panes/installedpane.py	2012-03-27 23:12:21 +0000
@@ -226,6 +226,9 @@
 
         self.hide_appview_spinner()
 
+        # keep track of the current view by tracking its origin
+        self.current_displayed_origin = None
+
         # now we are initialized
         self.emit("installed-pane-created")
 
@@ -655,11 +658,19 @@
             if self.state.search_term:
                 self._search()
             self._build_oneconfview()
-        else:
+        elif (view_state and
+              view_state.channel and
+              view_state.channel.origin is not self.current_displayed_origin):
+            # we don't need to refresh the full installed view every time it
+            # is displayed, so we check to see if we are viewing the same
+            # channel and if so we don't refresh the view, note that the view
+            # *is* is refreshed whenever the contents change and this is
+            # sufficient (see LP: #828887)
             self._build_categorised_installedview()
+            self.current_displayed_origin = view_state.channel.origin
 
-        if self.state.search_term:
-            self._search(self.state.search_term)
+            if self.state.search_term:
+                self._search(self.state.search_term)
         return True
 
     def get_current_app(self):
@@ -709,8 +720,11 @@
     w.init_view()
 
     from softwarecenter.backend.channel import AllInstalledChannel
+    from softwarecenter.ui.gtk3.panes.softwarepane import DisplayState
     w.state.channel = AllInstalledChannel()
-    w.display_overview_page(None, None)
+    view_state = DisplayState()
+    view_state.channel = AllInstalledChannel()
+    w.display_overview_page(None, view_state)
 
     win.show()
     return win