Merge lp:~gary-lasker/software-center/fix-crash-lp969732 into lp:software-center
Proposed by
Gary Lasker
Status: | Merged |
---|---|
Merge reported by: | Gary Lasker |
Merged at revision: | not available |
Proposed branch: | lp:~gary-lasker/software-center/fix-crash-lp969732 |
Merge into: | lp:software-center |
Diff against target: |
18 lines (+8/-0) 1 file modified
softwarecenter/ui/gtk3/models/appstore2.py (+8/-0) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/fix-crash-lp969732 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
software-store-developers | Pending | ||
Review via email: mp+104191@code.launchpad.net |
Description of the change
This branch fixes the crash described in bug 969732 by explicitly declaring the "needs-refresh" signal in the AppTreeStore class. Please see the description for bug 969732 where I have added steps to reproduce.
Thanks for your review!
To post a comment you must log in.
Thanks for this branch!
It looks good, but I'm a bit puzzled why its needed there as AppTreeStore does not itself defines
__gsignals__ so it should set this up itself. I also can't reproduce this issue because of a bug in
ubuntu-sso-client currently. But I wonder if its maybe a order issue? And would love to know if:
=== modified file 'softwarecenter /ui/gtk3/ models/ appstore2. py' ui/gtk3/ models/ appstore2. py 2012-03-30 09:11:08 +0000 ui/gtk3/ models/ appstore2. py 2012-05-01 21:50:46 +0000
--- softwarecenter/
+++ softwarecenter/
@@ -478,9 +478,9 @@
def __init__(self, db, cache, icons, icon_size= AppGenericStore .ICON_SIZE,
global_ icon_cache= True): .__init_ _(
Gtk.TreeStore .__init_ _(self) .__init_ _(
self. set_column_ types(self. COL_TYPES)
- AppGenericStore
- self, db, cache, icons, icon_size, global_icon_cache)
+ AppGenericStore
+ self, db, cache, icons, icon_size, global_icon_cache)
def set_documents(self, parent, documents):
works, i.e. just shuffling the __init__ around.