Merge lp:~gary-lasker/software-center/fix-crash-lp1021308 into lp:software-center
Proposed by
Gary Lasker
Status: | Merged |
---|---|
Merged at revision: | 3219 |
Proposed branch: | lp:~gary-lasker/software-center/fix-crash-lp1021308 |
Merge into: | lp:software-center |
Diff against target: |
103 lines (+16/-0) 8 files modified
softwarecenter/ui/gtk3/app.py (+2/-0) softwarecenter/ui/gtk3/views/appdetailsview.py (+2/-0) softwarecenter/ui/gtk3/widgets/apptreeview.py (+2/-0) softwarecenter/ui/gtk3/widgets/buttons.py (+2/-0) softwarecenter/ui/gtk3/widgets/containers.py (+2/-0) softwarecenter/ui/gtk3/widgets/description.py (+2/-0) softwarecenter/ui/gtk3/widgets/separators.py (+2/-0) softwarecenter/ui/gtk3/widgets/stars.py (+2/-0) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/fix-crash-lp1021308 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Lasker (community) | Needs Resubmitting | ||
Review via email: mp+127898@code.launchpad.net |
Description of the change
A branch to fix the crash in bug 1021308. Note that I am unable to reproduce the conditions that cause this crash, but the fix I've implemented should take care of it in a straightforward way for all children of the StatusBar class, and it has no discernable ill effects in my testing.
This one is currently #13 in the list of Quantal's top crashers at errors.ubuntu.com.
Many thanks for your review!
To post a comment you must log in.
Thanks for your branch.
I was able to reproduce the error using the instructions given in https:/ /bugs.launchpad .net/ubuntu/ +source/ software- center/ +bug/1021308/ comments/ 3 (actually it was enough to run software-center from the kubuntu live-cd in a VM to trigger it). I also put instructions how to reproduce on a normal ubuntu here: https:/ /bugs.launchpad .net/ubuntu/ +source/ software- center/ +bug/1021308/ comments/ 10
While this fixes the crash at hand there is another crash in the description widget plus the UI is in general in a pretty bad shape as the signal is needed in various other places as well, most noticeable in the applistview. So I think we need to fix all places where a "style-updated" signal is expected not just this one place.
Its probably easiest to simply do something like:
self. connect( "style- updated" , self.on_ style_updated) "style- updated" )
+ # workaround broken engines (LP: #1021308)
+ self.emit(
after each connect( "style- updated" ). Or to fix the engine, but given that lubuntu seems to have a similar problem
I suspect that there are various broken theme engines.