Merge lp:~gary-lasker/software-center/appdetailsview-button-focus-fix into lp:software-center

[Gary Lasker]

This branch grabs the initial focus to the action button ("Install"/"Remove") when showing the detailsview for an application.

Thanks!

[lp:~gary-lasker/software-center/appdetailsview-button-focus-fix]

2716. By Gary Lasker on 2012-02-02

merge with trunk and fix up changelog

[James Westby (james-w)]

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2012-02-02 20:20:58 +0000
+++ debian/changelog	2012-02-02 20:53:19 +0000
@@ -32,8 +32,11 @@
   * lp:~gary-lasker/software-center/recommends-ui-lobby:
     - initial recommends UI implementation, limited to non-personalized
       recommends currently
+  * lp:~gary-lasker/software-center/appdetailsview-button-focus-fix:
+    - make sure the action button in the applications details view
+      always gets the initial focus (LP: #925613)
 
- -- Gary Lasker <[e-mail]>  Thu, 02 Feb 2012 15:19:14 -0500
+ -- Gary Lasker <[e-mail]>  Thu, 02 Feb 2012 15:49:19 -0500
 
 software-center (5.1.7) precise; urgency=low
 
 
=== modified file 'softwarecenter/ui/gtk3/views/appdetailsview.py'
--- softwarecenter/ui/gtk3/views/appdetailsview.py	2012-02-02 13:05:06 +0000
+++ softwarecenter/ui/gtk3/views/appdetailsview.py	2012-02-02 20:53:19 +0000
@@ -1051,6 +1051,8 @@
 
     def _on_realize(self, widget):
         self.addons_statusbar.hide()
+        # the install button gets initial focus
+        self.pkg_statusbar.button.grab_focus()
         return
 
     def _on_homepage_clicked(self, label, link):
 
=== modified file 'test/gtk3/test_appdetailsview.py'
--- test/gtk3/test_appdetailsview.py	2012-02-02 13:31:14 +0000
+++ test/gtk3/test_appdetailsview.py	2012-02-02 20:53:19 +0000
@@ -56,6 +56,9 @@
         app = Application("", "abiword")
         self.view.show_app(app)
         do_events()
+        
+        # check that the action bar is given initial focus in the view
+        self.assertTrue(self.view.pkg_statusbar.button.has_focus())
 
         # create mock app
         mock_app = get_mock_app_from_real_app(app)
@@ -226,6 +229,7 @@
         self.view._submit_reviews_done_callback(None, 0)
 
         self.assertTrue(button.is_sensitive())
+        
 
 class HardwareRequirementsTestCase(unittest.TestCase):