Merge lp:~gandelman-a/ubuntu/saucy/keystone/2013.2.1 into lp:~ubuntu-server-dev/keystone/havana

Proposed by Adam Gandelman
Status: Merged
Approved by: Chuck Short
Approved revision: 243
Merged at revision: 241
Proposed branch: lp:~gandelman-a/ubuntu/saucy/keystone/2013.2.1
Merge into: lp:~ubuntu-server-dev/keystone/havana
Diff against target: 174 lines (+80/-17)
2 files modified
debian/changelog (+36/-1)
debian/patches/fix-ubuntu-tests.patch (+44/-16)
To merge this branch: bzr merge lp:~gandelman-a/ubuntu/saucy/keystone/2013.2.1
Reviewer Review Type Date Requested Status
Ubuntu Server Developers Pending
Review via email: mp+199722@code.launchpad.net

Commit message

2013.2.1

Description of the change

2013.2.1. WIP: Waiting on a patch from jdstrand to fix a test suite FTBFS introduced in stable/havana security update.

To post a comment you must log in.
Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Updated to include security fixes. Note that one patch applied by security team adjusted a test that came with the CVE fix, that requires a newer version of keystoneclient. We can safely skip the test on failure.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-12-18 18:39:07 +0000
+++ debian/changelog 2013-12-23 22:17:23 +0000
@@ -1,11 +1,46 @@
1keystone (1:2013.2.1-0ubuntu2) UNRELEASED; urgency=low1keystone (1:2013.2.1-0ubuntu1) saucy-proposed; urgency=low
22
3 * Resynchronize with stable/havana (03ed8c3) (LP: #1262788):
4 - [e6adb2f] Opening stable/havana
5 - [4221b60] Removing role adds role with LDAP backend LP: 1242855
6 - [3c25be5] Update memcache to match global requirements for stable/havana
7 - [d927273] Keystone tests determine rootdir relative to pwd LP: 1241198
8 - [64ac189] Updated from global requirements
9 - [03ed8c3] [OSSA 2013-032] Keystone trust circumvention through EC2-style
10 tokens (CVE-2013-6391) LP: 1242597
11 * Dropped patches, applied upstream:
12 - debian/patches/CVE-2013-4477.patch: [4221b60]
13 - debian/patches/CVE-2013-6391.patch: [03ed8c3]
14 * debian/patches/fix-ubuntu-tests.patch: Update to skip a test introduced
15 with [03ed8c3] that requires a more recent version of
16 python-keystoneclient.
3 * debian/patches/revert-stable-havana-requirements.patch: Revert17 * debian/patches/revert-stable-havana-requirements.patch: Revert
4 version bumps to dependencies in stable/havana back to what was18 version bumps to dependencies in stable/havana back to what was
5 shipped with Saucy.19 shipped with Saucy.
620
7 -- Adam Gandelman <adamg@ubuntu.com> Tue, 17 Dec 2013 20:08:25 -080021 -- Adam Gandelman <adamg@ubuntu.com> Tue, 17 Dec 2013 20:08:25 -0800
822
23keystone (1:2013.2-0ubuntu1.2) saucy-security; urgency=low
24
25 * SECURITY UPDATE: Keystone trust circumvention through EC2-style tokens
26 - debian/patches/CVE-2013-6391.patch: addjust to store the trust_id with
27 the ec2 keypair and pass this with metadata when requesting v2 token
28 - CVE-2013-6391
29 - LP: #1242597
30
31 -- Jamie Strandboge <jamie@ubuntu.com> Thu, 19 Dec 2013 13:45:15 -0600
32
33keystone (1:2013.2-0ubuntu1.1) saucy-security; urgency=low
34
35 * SECURITY UPDATE: don't add role when attempting to remove a non-existent
36 role
37 - debian/patches/CVE-2013-4477.patch: raise RoleNotFound with exception
38 ldap.NO_SUCH_OBJECT
39 - CVE-2013-4477
40 - LP: #1242855
41
42 -- Jamie Strandboge <jamie@ubuntu.com> Tue, 05 Nov 2013 09:06:12 -0600
43
9keystone (1:2013.2-0ubuntu1) saucy; urgency=low44keystone (1:2013.2-0ubuntu1) saucy; urgency=low
1045
11 * New upstream release (LP: #1236462).46 * New upstream release (LP: #1236462).
1247
=== modified file 'debian/patches/fix-ubuntu-tests.patch'
--- debian/patches/fix-ubuntu-tests.patch 2013-12-18 04:08:31 +0000
+++ debian/patches/fix-ubuntu-tests.patch 2013-12-23 22:17:23 +0000
@@ -1,7 +1,7 @@
1Index: keystone/keystone/tests/test_associate_project_endpoint_extension.py1Index: keystone/keystone/tests/test_associate_project_endpoint_extension.py
2===================================================================2===================================================================
3--- keystone.orig/keystone/tests/test_associate_project_endpoint_extension.py 2013-12-17 20:02:48.219728454 -08003--- keystone.orig/keystone/tests/test_associate_project_endpoint_extension.py 2013-12-23 14:12:31.076093251 -0800
4+++ keystone/keystone/tests/test_associate_project_endpoint_extension.py 2013-12-17 20:02:48.211728454 -08004+++ keystone/keystone/tests/test_associate_project_endpoint_extension.py 2013-12-23 14:12:31.068093251 -0800
5@@ -17,6 +17,8 @@5@@ -17,6 +17,8 @@
6 import os6 import os
7 import uuid7 import uuid
@@ -25,8 +25,8 @@
25 def setUp(self):25 def setUp(self):
26Index: keystone/keystone/tests/test_content_types.py26Index: keystone/keystone/tests/test_content_types.py
27===================================================================27===================================================================
28--- keystone.orig/keystone/tests/test_content_types.py 2013-12-17 20:02:48.219728454 -080028--- keystone.orig/keystone/tests/test_content_types.py 2013-12-23 14:12:31.076093251 -0800
29+++ keystone/keystone/tests/test_content_types.py 2013-12-17 20:02:48.211728454 -080029+++ keystone/keystone/tests/test_content_types.py 2013-12-23 14:12:31.068093251 -0800
30@@ -15,6 +15,7 @@30@@ -15,6 +15,7 @@
31 # under the License.31 # under the License.
32 32
@@ -67,8 +67,8 @@
67 """Convenience method so that we can test authenticated requests."""67 """Convenience method so that we can test authenticated requests."""
68Index: keystone/keystone/tests/test_keystoneclient.py68Index: keystone/keystone/tests/test_keystoneclient.py
69===================================================================69===================================================================
70--- keystone.orig/keystone/tests/test_keystoneclient.py 2013-12-17 20:02:48.219728454 -080070--- keystone.orig/keystone/tests/test_keystoneclient.py 2013-12-23 14:12:31.076093251 -0800
71+++ keystone/keystone/tests/test_keystoneclient.py 2013-12-17 20:02:48.211728454 -080071+++ keystone/keystone/tests/test_keystoneclient.py 2013-12-23 14:12:31.068093251 -0800
72@@ -16,6 +16,7 @@72@@ -16,6 +16,7 @@
73 73
74 import uuid74 import uuid
@@ -147,8 +147,8 @@
147 # NOTE(termie): update_enabled doesn't return anything, probably a bug147 # NOTE(termie): update_enabled doesn't return anything, probably a bug
148Index: keystone/keystone/tests/test_no_admin_token_auth.py148Index: keystone/keystone/tests/test_no_admin_token_auth.py
149===================================================================149===================================================================
150--- keystone.orig/keystone/tests/test_no_admin_token_auth.py 2013-12-17 20:02:48.219728454 -0800150--- keystone.orig/keystone/tests/test_no_admin_token_auth.py 2013-12-23 14:12:31.076093251 -0800
151+++ keystone/keystone/tests/test_no_admin_token_auth.py 2013-12-17 20:02:48.211728454 -0800151+++ keystone/keystone/tests/test_no_admin_token_auth.py 2013-12-23 14:12:31.068093251 -0800
152@@ -16,6 +16,7 @@152@@ -16,6 +16,7 @@
153 153
154 import os154 import os
@@ -171,8 +171,8 @@
171 self.loadapp(tests.tmpdir('no_admin_token_auth'), name='admin'),171 self.loadapp(tests.tmpdir('no_admin_token_auth'), name='admin'),
172Index: keystone/keystone/tests/test_v3.py172Index: keystone/keystone/tests/test_v3.py
173===================================================================173===================================================================
174--- keystone.orig/keystone/tests/test_v3.py 2013-12-17 20:02:48.219728454 -0800174--- keystone.orig/keystone/tests/test_v3.py 2013-12-23 14:12:31.076093251 -0800
175+++ keystone/keystone/tests/test_v3.py 2013-12-17 20:02:48.211728454 -0800175+++ keystone/keystone/tests/test_v3.py 2013-12-23 14:12:31.072093251 -0800
176@@ -18,6 +18,7 @@176@@ -18,6 +18,7 @@
177 import uuid177 import uuid
178 178
@@ -207,8 +207,8 @@
207 self.project = self.new_project_ref(207 self.project = self.new_project_ref(
208Index: keystone/keystone/tests/test_v3_protection.py208Index: keystone/keystone/tests/test_v3_protection.py
209===================================================================209===================================================================
210--- keystone.orig/keystone/tests/test_v3_protection.py 2013-12-17 20:02:48.219728454 -0800210--- keystone.orig/keystone/tests/test_v3_protection.py 2013-12-23 14:12:31.076093251 -0800
211+++ keystone/keystone/tests/test_v3_protection.py 2013-12-17 20:02:48.211728454 -0800211+++ keystone/keystone/tests/test_v3_protection.py 2013-12-23 14:12:31.072093251 -0800
212@@ -16,6 +16,7 @@212@@ -16,6 +16,7 @@
213 # under the License.213 # under the License.
214 214
@@ -240,8 +240,8 @@
240 self.identity_api.create_domain(self.domainA['id'], self.domainA)240 self.identity_api.create_domain(self.domainA['id'], self.domainA)
241Index: keystone/keystone/tests/test_wsgi.py241Index: keystone/keystone/tests/test_wsgi.py
242===================================================================242===================================================================
243--- keystone.orig/keystone/tests/test_wsgi.py 2013-12-17 20:02:48.219728454 -0800243--- keystone.orig/keystone/tests/test_wsgi.py 2013-12-23 14:12:31.076093251 -0800
244+++ keystone/keystone/tests/test_wsgi.py 2013-12-17 20:02:48.211728454 -0800244+++ keystone/keystone/tests/test_wsgi.py 2013-12-23 14:12:31.072093251 -0800
245@@ -15,6 +15,7 @@245@@ -15,6 +15,7 @@
246 # under the License.246 # under the License.
247 247
@@ -288,8 +288,8 @@
288 if (user_locale == LANG_ID and288 if (user_locale == LANG_ID and
289Index: keystone/run_tests.sh289Index: keystone/run_tests.sh
290===================================================================290===================================================================
291--- keystone.orig/run_tests.sh 2013-12-17 20:02:48.219728454 -0800291--- keystone.orig/run_tests.sh 2013-12-23 14:12:31.076093251 -0800
292+++ keystone/run_tests.sh 2013-12-17 20:02:48.215728454 -0800292+++ keystone/run_tests.sh 2013-12-23 14:12:31.072093251 -0800
293@@ -70,7 +70,7 @@293@@ -70,7 +70,7 @@
294 never_venv=0294 never_venv=0
295 force=0295 force=0
@@ -299,3 +299,31 @@
299 wrapper=""299 wrapper=""
300 just_flake8=0300 just_flake8=0
301 short_flake8=0301 short_flake8=0
302Index: keystone/keystone/tests/test_keystoneclient_sql.py
303===================================================================
304--- keystone.orig/keystone/tests/test_keystoneclient_sql.py 2013-12-23 14:11:56.408093565 -0800
305+++ keystone/keystone/tests/test_keystoneclient_sql.py 2013-12-23 14:14:14.980092310 -0800
306@@ -14,6 +14,7 @@
307 # License for the specific language governing permissions and limitations
308 # under the License.
309
310+import nose
311 import uuid
312
313 from keystoneclient.contrib.ec2 import utils as ec2_utils
314@@ -136,8 +137,13 @@
315
316 # Create a client for user_two, scoped to the trust
317 client = self.get_client(self.user_two)
318- ret = client.authenticate(trust_id=trust_id,
319- tenant_id=self.tenant_bar['id'])
320+ try:
321+ ret = client.authenticate(trust_id=trust_id,
322+ tenant_id=self.tenant_bar['id'])
323+ except:
324+ m = 'Skipped by Ubuntu-- need python-keystoneclient 0.4.1'
325+ raise nose.exc.SkipTest(m)
326+ self.assertTrue(ret)
327 self.assertTrue(ret)
328 self.assertTrue(client.auth_ref.trust_scoped)
329 self.assertEqual(trust_id, client.auth_ref.trust_id)

Subscribers

People subscribed via source and target branches