Merge lp:~gagern/lightdm/preferred-users into lp:lightdm
Proposed by
Martin von Gagern
Status: | Needs review |
---|---|
Proposed branch: | lp:~gagern/lightdm/preferred-users |
Merge into: | lp:lightdm |
Diff against target: |
73 lines (+31/-1) 2 files modified
common/user-list.c (+29/-1) data/users.conf (+2/-0) |
To merge this branch: | bzr merge lp:~gagern/lightdm/preferred-users |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Needs Information | ||
Review via email: mp+217720@code.launchpad.net |
Description of the change
In the absence of AccountsService, this patch allows for a preferred-users setting in the users.conf file which will result in the named users getting sorted to the top of the list, in the order in which they have been specified. This is particularly important if the greeter presents the first user as the default selection, like the gtk greeter does. That way, the person owning the computer can log simply by typing his password, even if there are other accounts on the system.
To post a comment you must log in.
Unmerged revisions
- 1821. By Martin von Gagern
-
Document preferred-users setting in users.conf.
- 1820. By Martin von Gagern
-
Merge the rename from LightDMUser to CommonUser.
- 1819. By Martin von Gagern
-
Allow for a preferred-users setting to affect user list ordering.
I've been mulling this over and I need some convincing this feature is important.
You mention the case where the GTK+ greeter always selects the first user, not the most common user account. Isn't this just a bug in the GTK+ greeter? Would it selecting the last logged in user solve this?
For this to be in LightDM the feature should be useful for all greeters. Given the above statement, I'm not sure why other greeters might want this feature.
If this feature did exist, it should apply to the ordering of the user list even if it's from AccountsService otherwise the behaviour is inconsistent.
There are some bugs: rivate, not a static variable. At the moment you overwrite it each time load_passwd_file is called which happens each time /etc/passwd changes and also you may have more than one instance of CommonUserList.
- You read the config from [UserList] but data/users.conf says it is in [UserAccounts]
- preferred_users should be a field in CommonUserListP